Decide what to do with <TestPipes.cpp> |#if 0|'ed code

RESOLVED FIXED in mozilla1.9.1b2

Status

()

defect
--
trivial
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
mozilla1.9.1b2
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Assignee

Description

11 years ago
Bug 453137 comment 5
{
From  Serge Gautherie   2008-09-18 14:07:38 PDT

PS: I don't know if you want to do something about the |#ifdef 0| code(s),
either way...
}

*****

There is 2 parts:

1) |#if 0   // obsolete old implementation|

{
rv = TP_NewPipe(getter_AddRefs(in), getter_AddRefs(out), 4096 * 4);
rv = TestPipe(in, out);
}
is now covered by
{
RunTests(4096, 16);
}
then, if we're good with the current 4->16 change,
this code should simply be removed.

2) |TestSearch()|

{
rv = in->Search(delim, PR_FALSE, &found, &offset);
}
I don't see any Search() method in nsIInputStream.idl nor in nsIAsyncInputStream.idl...
Is it another "non-exported" method ?
Assignee

Comment 1

11 years ago
The obvious part.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #340680 - Flags: review?(benjamin)
Assignee

Comment 2

11 years ago
New issue, moved from bug 453137 comment 11.

Fwiw, this (test) function is only used in this test.
http://mxr.mozilla.org/mozilla-central/search?string=TestSegmentedBuffer&case=on

I tried to look in /xpcom/*, but I didn't find out what makes the test function be unavailable with '--enable-libxul' :-<
http://mxr.mozilla.org/mozilla-central/search?string=nsSegmentedBuffer&case=on
Attachment #340683 - Flags: review?(benjamin)

Updated

11 years ago
Attachment #340680 - Flags: review?(benjamin) → review+

Updated

11 years ago
Attachment #340683 - Flags: review?(benjamin) → review+
Assignee

Updated

11 years ago
Keywords: checkin-needed
Whiteboard: [c-n (when tree reopens): Av1, Bv1 // Leave opened]
Assignee

Comment 3

11 years ago
Comment on attachment 340680 [details] [diff] [review]
(Av1) Remove replaced |#if 0| code
[Checkin: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/03bcf290b1fb
Attachment #340680 - Attachment description: (Av1) Remove replaced |#if 0| code → (Av1) Remove replaced |#if 0| code [Checkin: Comment 3]
Assignee

Comment 4

11 years ago
Comment on attachment 340683 [details] [diff] [review]
(Bv1) TestSegmentedBuffer()
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/f87c1b3d0a19
Attachment #340683 - Attachment description: (Bv1) TestSegmentedBuffer() → (Bv1) TestSegmentedBuffer() [Checkin: Comment 4]
Assignee

Updated

11 years ago
Keywords: checkin-needed
Whiteboard: [c-n (when tree reopens): Av1, Bv1 // Leave opened]
Target Milestone: --- → mozilla1.9.1b2
Assignee

Comment 5

11 years ago
Benjamin, could you answer my comment 0 question about |Search()| ?

Comment 6

11 years ago
Probably lost in the sands of time, can we just remove the unbuilt code?
Assignee

Comment 7

11 years ago
See bug 46777 comment 4:
{
From  Warren Harris   2000-08-18 23:59:41 PDT

the Search method on pipes went away
}
Attachment #342262 - Flags: review?(benjamin)
Assignee

Updated

11 years ago
Depends on: 46777
Flags: in-testsuite+

Updated

11 years ago
Attachment #342262 - Flags: review?(benjamin) → review+
Assignee

Updated

11 years ago
Attachment #342262 - Attachment description: (Cv1) Remove obsolete |#if 0| code → (Cv1) Remove obsolete |#if 0| code [Checkin: Comment 8]
Assignee

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.