457046 - Decide what to do with <TestPipes.cpp> |#if 0|'ed code

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 453137 comment 5
{
From  Serge Gautherie   2008-09-18 14:07:38 PDT

PS: I don't know if you want to do something about the |#ifdef 0| code(s),
either way...
}

*****

There is 2 parts:

1) |#if 0   // obsolete old implementation|

{
rv = TP_NewPipe(getter_AddRefs(in), getter_AddRefs(out), 4096 * 4);
rv = TestPipe(in, out);
}
is now covered by
{
RunTests(4096, 16);
}
then, if we're good with the current 4->16 change,
this code should simply be removed.

2) |TestSearch()|

{
rv = in->Search(delim, PR_FALSE, &found, &offset);
}
I don't see any Search() method in nsIInputStream.idl nor in nsIAsyncInputStream.idl...
Is it another "non-exported" method ?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove replaced |#if 0| code [Checkin: Comment 3]

The obvious part.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) TestSegmentedBuffer() [Checkin: Comment 4]

New issue, moved from bug 453137 comment 11.

Fwiw, this (test) function is only used in this test.
http://mxr.mozilla.org/mozilla-central/search?string=TestSegmentedBuffer&case=on

I tried to look in /xpcom/*, but I didn't find out what makes the test function be unavailable with '--enable-libxul' :-<
http://mxr.mozilla.org/mozilla-central/search?string=nsSegmentedBuffer&case=on

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 340680 [details] [diff] [review]
(Av1) Remove replaced |#if 0| code
[Checkin: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/03bcf290b1fb

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 340683 [details] [diff] [review]
(Bv1) TestSegmentedBuffer()
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/f87c1b3d0a19

Comment 5

[Serge Gautherie (:sgautherie)]

Benjamin, could you answer my comment 0 question about |Search()| ?

Comment 6

[Benjamin Smedberg]

Probably lost in the sands of time, can we just remove the unbuilt code?

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Remove obsolete |#if 0| code [Checkin: Comment 8]

See bug 46777 comment 4:
{
From  Warren Harris   2000-08-18 23:59:41 PDT

the Search method on pipes went away
}

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 342262 [details] [diff] [review]
(Cv1) Remove obsolete |#if 0| code
[Checkin: Comment 8]

http://hg.mozilla.org/mozilla-central/rev/0db169d84c72