457214 - Broken Qt port configuring

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Anton Rogaynis (antonr)]

configure fails while checking DBus support.

Comment 1

[(not currently active) Ted Mielczarek]

Bugs filed without any error output are not very useful. Does it just error telling you it couldn't find dbus? If so, either --disable-dbus or install dbus devel packages. If this is something else, then please paste the output so we have a chance in hell of figuring out what you mean.

Comment 2

[Anton Rogaynis (antonr)]

checking LIBOSSO_LIBS... -losso -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0  
configure: error: DBus is required when building for OSSO
*** Fix above errors and then restart with               "make -f client.mk build"
make[1]: *** [configure] Error 1
make[1]: Leaving directory `/mozilla/trunk/microb-engine/microb-engine/build-tree/mozilla'
make: *** [configure-stamp] Error 2

Comment 3

[Anton Rogaynis (antonr)]

Attachment: Patch to fix

Comment 4

[(not currently active) Ted Mielczarek]

What does this fix exactly?

Comment 5

[Anton Rogaynis (antonr)]

fixes broken condition.

Comment 6

[Oleg Romashin (:romaxa)]

(In reply to comment #4)
> What does this fix exactly?

Previous fix from bug 454391 was broken...
Even with MOZ_ENABLE_QT == 1 next condition will fail:
if test "$MOZ_ENABLE_GTK2" || "$MOZ_ENABLE_QT"

after || should be test, see:
http://mxr.mozilla.org/mozilla-central/source/configure.in#700

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 340566 [details] [diff] [review]
Patch to fix

Yeah, I realized that after asking the question. Reporter: please provide more details when filing bug reports and attaching patches. It's a lot more useful than making me guess at what you're trying to say.

Comment 8

[Oleg Romashin (:romaxa)]

Fixed in:

http://hg.mozilla.org/mozilla-central/rev/aa4d3083995f