Last Comment Bug 457226 - mochitest for ARIA states
: mochitest for ARIA states
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: x86 All
: -- normal (vote)
: mozilla11
Assigned To: Marco Zehe (:MarcoZ)
:
Mentors:
Depends on: 457219
Blocks: a11ytestdev
  Show dependency treegraph
 
Reported: 2008-09-26 07:13 PDT by alexander :surkov
Modified: 2011-12-09 07:07 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Missing test cases (3.18 KB, patch)
2011-12-08 02:54 PST, Marco Zehe (:MarcoZ)
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2008-09-26 07:13:22 PDT
initally assigning to me, Marco feel free to take this.
Comment 1 Marco Zehe (:MarcoZ) 2008-09-26 23:02:02 PDT
Note to whoever ends up taking this:
- Check that checked/unchecked are not present at the same time similar to the other tests in common.js after bug 457219 lands.
Comment 2 David Bolter [:davidb] 2009-05-07 13:22:03 PDT
We don't have an unchecked state. We do have checks for combinations of checked+mixed. There are some aria states currently tested in test_aria_token_attrs.html and test_states.html.

Do we want to do more with this bug? Maybe we should make sure all possible aria states are hit in test_states.html?
Comment 3 Marco Zehe (:MarcoZ) 2009-05-07 14:02:36 PDT
Yes, that would be the place to go.
Comment 4 alexander :surkov 2009-05-07 17:05:30 PDT
(In reply to comment #2)

> Do we want to do more with this bug? Maybe we should make sure all possible
> aria states are hit in test_states.html?

yes, iirc that's reason I filed this bug. reassigning to default assigne I don't think I will be really soon here.
Comment 5 Trevor Saunders (:tbsaunde) 2011-02-19 22:19:02 PST
It's  been a year and a half, and we know have states/test_aria.html is that aenough state checking for aria?  If not what do we still need to test?
Comment 6 alexander :surkov 2011-02-20 21:15:19 PST
(In reply to comment #5)
>  If not what do we still need to test?

somebody should run through nsARIAMap.cpp and add missed states to test_aria.html
Comment 7 Marco Zehe (:MarcoZ) 2011-12-08 02:54:56 PST
Created attachment 579994 [details] [diff] [review]
Missing test cases
Comment 8 alexander :surkov 2011-12-08 06:41:00 PST
Comment on attachment 579994 [details] [diff] [review]
Missing test cases


>+      // aria-selectable
>+      testStates("aria_selectable_listitem", STATE_SELECTABLE | STATE_SELECTED);
>+
>+      //

some artifact

is readonly state test for aria-readonly missed?
Comment 9 Marco Zehe (:MarcoZ) 2011-12-08 06:51:29 PST
(In reply to alexander :surkov from comment #8)
> Comment on attachment 579994 [details] [diff] [review]
> Missing test cases
> 
> 
> >+      // aria-selectable
> >+      testStates("aria_selectable_listitem", STATE_SELECTABLE | STATE_SELECTED);
> >+
> >+      //
> 
> some artifact

OK, will remove before checkin.

> is readonly state test for aria-readonly missed?


I saw it tested in another part of the file, so didn't put one here.
Comment 10 alexander :surkov 2011-12-08 06:56:10 PST
(In reply to Marco Zehe (:MarcoZ) from comment #9)

> > is readonly state test for aria-readonly missed?
> I saw it tested in another part of the file, so didn't put one here.

of this file? It has aria-readonly occasionally, not sure on what propose but I don't see we test READONLY state.
Comment 11 Marco Zehe (:MarcoZ) 2011-12-08 08:05:12 PST
Landed on inbound with comments addressed: http://hg.mozilla.org/integration/mozilla-inbound/rev/8a49a1709b30
Comment 12 Ed Morley [:emorley] 2011-12-09 07:07:39 PST
https://hg.mozilla.org/mozilla-central/rev/8a49a1709b30

Note You need to log in before you can comment on or make changes to this bug.