457226 - mochitest for ARIA states

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

initally assigning to me, Marco feel free to take this.

Comment 1

[Marco Zehe (:MarcoZ)]

Note to whoever ends up taking this:
- Check that checked/unchecked are not present at the same time similar to the other tests in common.js after bug 457219 lands.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

We don't have an unchecked state. We do have checks for combinations of checked+mixed. There are some aria states currently tested in test_aria_token_attrs.html and test_states.html.

Do we want to do more with this bug? Maybe we should make sure all possible aria states are hit in test_states.html?

Comment 3

[Marco Zehe (:MarcoZ)]

Yes, that would be the place to go.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #2)

> Do we want to do more with this bug? Maybe we should make sure all possible
> aria states are hit in test_states.html?

yes, iirc that's reason I filed this bug. reassigning to default assigne I don't think I will be really soon here.

Comment 5

[Trevor Saunders (:tbsaunde)]

It's  been a year and a half, and we know have states/test_aria.html is that aenough state checking for aria?  If not what do we still need to test?

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #5)
>  If not what do we still need to test?

somebody should run through nsARIAMap.cpp and add missed states to test_aria.html

Comment 7

[Marco Zehe (:MarcoZ)]

Attachment: Missing test cases

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 579994 [details] [diff] [review]
Missing test cases


>+      // aria-selectable
>+      testStates("aria_selectable_listitem", STATE_SELECTABLE | STATE_SELECTED);
>+
>+      //

some artifact

is readonly state test for aria-readonly missed?

Comment 9

[Marco Zehe (:MarcoZ)]

(In reply to alexander :surkov from comment #8)
> Comment on attachment 579994 [details] [diff] [review]
> Missing test cases
> 
> 
> >+      // aria-selectable
> >+      testStates("aria_selectable_listitem", STATE_SELECTABLE | STATE_SELECTED);
> >+
> >+      //
> 
> some artifact

OK, will remove before checkin.

> is readonly state test for aria-readonly missed?


I saw it tested in another part of the file, so didn't put one here.

Comment 10

[alexander :surkov (:asurkov)]

(In reply to Marco Zehe (:MarcoZ) from comment #9)

> > is readonly state test for aria-readonly missed?
> I saw it tested in another part of the file, so didn't put one here.

of this file? It has aria-readonly occasionally, not sure on what propose but I don't see we test READONLY state.

Comment 11

[Marco Zehe (:MarcoZ)]

Landed on inbound with comments addressed: http://hg.mozilla.org/integration/mozilla-inbound/rev/8a49a1709b30

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8a49a1709b30