457344 - Win98 users doesn't seem to get an offer to update from 2.0.0.16 to 2.0.0.17

Status: VERIFIED FIXED

(AUS Graveyard :: General, defect)

Description

[Matthias Versen [:Matti]]

I can not reproduce this myself but someone should look at this if possible.
I saw 2 different people on heise.de claiming that they don't get an offer to update from Firefox 2.0.0.16 to 2.0.0.17 under Windoes98
It seems that they also manually tried it but they got the info "no updates available".

Is it possible that the update block that should block an update to 3.X under windows98SE also blocks minor updates ?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Sounds like fallout from bug 418129. Some URLs
  https://aus2.mozilla.org/update/3/Firefox/2.0.0.16/2008070205/WINNT_x86-msvc/en-US/release/Windows_NT%205.1/default/default/update.xml
  https://aus2.mozilla.org/update/3/Firefox/2.0.0.16/2008070205/WINNT_x86-msvc/en-US/release/Windows_NT%204/default/default/update.xml
  https://aus2.mozilla.org/update/3/Firefox/2.0.0.16/2008070205/WINNT_x86-msvc/en-US/release/Windows_98/default/default/update.xml
I'm not getting any update info returned for the NT 4 and 98 cases. 

From a quick check on the Linux I would guess that everything in 
 http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/config-dist.php#151
is not getting 2.0.0.x -> 2.0.0.x updates. Something wrong with the $updateType == 'minor' test in isSupported() ?

Comment 2

[VanillaMozilla]

Er, not fixed here, yet.  Should we just be patient or should the bug be reopened?

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16

Comment 3

[Michael Morgan [:morgamic]]

Behavior from bug 418129 is only supposed to work with major updates.  Is this update a major update?

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> Behavior from bug 418129 is only supposed to work with major updates.  Is this
> update a major update?

AUS and patcher are both broken. Patcher seems to only set the updateType if the update is major, and AUS never sets a default for updateType, so without an updateType for minor updates, this block of code never becomes true, and therefore, platform checking is applied for both major and minor updates:

476         // If it's not a major update, we're not blocking platforms.
477         if ($updateType == 'minor' || empty($unsupportedPlatforms[$product])) {
478             return true;
479         }

Quick fix is to make AUS set a default of updateType being minor if it's not set, but really patcher should be setting updateType for all snippets, not just major update ones. I'm working on a patch. Should be posted shortly.

Comment 5

[Michael Morgan [:morgamic]]

The update class has a default of minor, but it is overridden if patcher offers one.

Comment 6

[Reed Loden [:reed]]

Attachment: patch - v1

Set updateType to 'minor' by default when initializing a new patch class. Test included. Nothing tested, as I don't have a local AUS instance to use for testing.

Comment 7

[Michael Morgan [:morgamic]]

Attachment: Additional tests, and some other changes for URL encoding

Comment 8

[Michael Morgan [:morgamic]]

Attachment: Revised tests to cover all ignored OSes with minor update types

Comment 9

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/8000000004/locale/channel/complete.txt,v
done
Checking in tests/data/3/Synthetic/1.0/platform/8000000004/locale/channel/complete.txt;
/cvsroot/mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/8000000004/locale/channel/complete.txt,v  <--  complete.txt
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/8000000004/locale/channel/partial.txt,v
done
Checking in tests/data/3/Synthetic/1.0/platform/8000000004/locale/channel/partial.txt;
/cvsroot/mozilla/webtools/aus/tests/data/3/Synthetic/1.0/platform/8000000004/locale/channel/partial.txt,v  <--  partial.txt
initial revision: 1.1
done
Checking in xml/inc/patch.class.php;
/cvsroot/mozilla/webtools/aus/xml/inc/patch.class.php,v  <--  patch.class.php
new revision: 1.23; previous revision: 1.22
done

Comment 10

[Michael Morgan [:morgamic]]

Checking in tests/Verify.py;
/cvsroot/mozilla/webtools/aus/tests/Verify.py,v  <--  Verify.py
new revision: 1.7; previous revision: 1.6
done
Checking in tests/Verify.txt;
/cvsroot/mozilla/webtools/aus/tests/Verify.txt,v  <--  Verify.txt
new revision: 1.12; previous revision: 1.11
done

Comment 11

[Reed Loden [:reed]]

https://aus2-staging.mozilla.org has been updated with the new patch. Once QA has looked over it and confirmed that the problem is fixed, we'll get the production AUS2 instance updated. Any help testing would be appreciated!

Comment 12

[Carsten Book [:Tomcat]]

(In reply to comment #11)
> https://aus2-staging.mozilla.org has been updated with the new patch. Once QA
> has looked over it and confirmed that the problem is fixed, we'll get the
> production AUS2 instance updated. Any help testing would be appreciated!

Starting now the Tests - Tomcat

Comment 13

[Carsten Book [:Tomcat]]

(In reply to comment #12)
> Starting now the Tests - Tomcat

Tests are done now and tests for Windows (NT and Windows 98) and also Ubuntu 6.06.01 PASS. 

I'm not really able to test Mac 10.3 

I also confirmed working updates on aus2-staging for Windows XP and Mac 10.5 

Results are added to https://wiki.mozilla.org/QA/Firefox3/TestPlan/MajorUpdate/Results:20016_fx3.0.1#Retest_for_Bug_457344_-_Tomcat

Comment 14

[Reed Loden [:reed]]

Bug 457489 filed to get AUS2 production updated.

Comment 15

[Ant]

> I can not reproduce this myself but someone should look at this if possible.
> I saw 2 different people on heise.de claiming that they don't get an offer to
> update from Firefox 2.0.0.16 to 2.0.0.17 under Windoes98
> It seems that they also manually tried it but they got the info "no updates
> available".
> 
> Is it possible that the update block that should block an update to 3.X under
> windows98SE also blocks minor updates ?

I was able to reproduce this with my dad's old laptop/notebook with Firefox v2.0.0.16 and Windows 98 SE. I had to download and install v2.0.0.17 with its installer.

Comment 16

[Carsten Book [:Tomcat]]

verified fixed using my windows 98 VM. Update to 2.0.0.17 works like expected now.