457461 - Different keyboard shortcuts for the same actions in main window and event/task dialog

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[pavel.zahradnik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Lightning 0.9

There are some different hotkeys for the same actions which is confusing for user:

New message: Ctrl+N in main Thunderbird window, but Ctrl+M in Event/Task dialog
New event: Ctrl+I in main Thunderbird window, but Ctrl+E in Event/Task dialog

Maybe there are some others.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Martin Schröder [:mschroeder]]

Confirmed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081117 Lightning/1.0pre Shredder/3.0b1pre.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This patch takes care. This patch also proposes to get rid of the key for "Delete". I think its a good idea since the "Delete" key was right next to the "Save" key. If you expect a confirmation message, then you might not read it and accidentally delete your event or task.

This patch also adds the possibility to create a new task from the dialog, re-using the Ctrl+D key, which also matches the key in the main UI.

Comment 3

[Markus Adrario [:Taraman]]

Comment on attachment 432629 [details] [diff] [review]
Fix - v1

Patch performs as expected.

some style nits:
>+    args.onNewTodo= function(calendar) {
>+        createTodoWithDialog(calendar);
>+    };
>+
> 
>     // the dialog will reset this to auto when it is done loading.
>     window.setCursor("wait");
remove extra newline here,

>+/**
>+
>+ * Use the window arguments to cause the opener to create a new event on the
and here.

>+<!ENTITY event.dialog.new.event.key2              "I">
>+<!ENTITY event.dialog.new.task.key2               "D">
>+<!ENTITY event.dialog.new.message.key2            "N">
are these named .key2 on purpose?
If not, the same applies below.

>-    <keyset>
>+    <keyset id="itemKeys">
>         <key id="new-event-key"
>              modifiers="control"
>-             key="&event.dialog.new.event.key;"
>+             key="&event.dialog.new.event.key2;"
>              command="cmd_item_new_event"/>
>+        <key id="new-task-key"
>+             modifiers="control"
>+             key="&event.dialog.new.task.key2;"
>+             command="cmd_item_new_task"/>
>         <key id="new-message-key"
>              modifiers="accel"
>-             key="&event.dialog.new.message.key;"
>+             key="&event.dialog.new.message.key2;"
>              command="cmd_item_new_message"/>
modifier is "control" here. should be accel as in existing keys for mac-compatibility.

with these fixed
r=markus

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #3)
> >+<!ENTITY event.dialog.new.event.key2              "I">
> >+<!ENTITY event.dialog.new.task.key2               "D">
> >+<!ENTITY event.dialog.new.message.key2            "N">
> are these named .key2 on purpose?

Yes, I need to rename the entity if I change it (for the l10n scripts to pick up the change), and changing the pattern seemed wrong to me, and there's no alternative word for "event".

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/bbd3d3684c04>

-> FIXED