457491 - Bookmarks toolbar: left side of buttons' rounded edge is offset by 1 pixel with search box present

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jason Oster (:Parasyte)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008091618 Firefox/3.0.2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008091618 Firefox/3.0.2

Hovering over the bookmarks toolbar buttons while the quick search bar (or other "tall" item) is placed into the toolbar shows the left side of the rounded edge on buttons is offset by 1 pixel (or more).

See screenshot.

Reproducible: Always

Steps to Reproduce:
1. Customize your bookmarks toolbar, moving the quick search bar into it.
2. Hover your mouse over one of the toolbar buttons.

Comment 1

[Jason Oster (:Parasyte)]

Attachment: Left side of my "Home" button is vertically offset by 1 pixel

Comment 2

[Jason Oster (:Parasyte)]

Attachment: Fixes the issue by ensuring an evenly centered .bookmark-item class

This patch seems to fix the problem without causing regressions. Requesting review.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 340790 [details] [diff] [review]
Fixes the issue by ensuring an evenly centered .bookmark-item class

This doesn't need ui-review - thanks for the patch!

Comment 4

[Dietrich Ayala (:dietrich)]

pushed: http://hg.mozilla.org/mozilla-central/rev/dd633cd93252

Comment 5

[amau96]

Attachment: The last patch is good but not enought

if you look carefully you will notice that the gray on the left is not uniform, you can see the demarcation.

Comment 6

[amau96]

	
if you look carefully you will notice that the gray on the left is not uniform, you can see the demarcation, please re-open the bug to realy fix it. And i think that there is still an one pixel offset probleme in the top left.