457648 - ui for shortcut editor

Status: VERIFIED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel Brooks [:db48x]]

Currently the shortcut editor uses a tree, which makes implementing inline editing fairly easy. However, I don't think it will work well with commands that have more than one keyboard shortcut (of which there are already several.)

I'm not quite sure what will work best, though. Perhaps something similar to the prefs window, where it shows a two-line description and the primary shortcut for each command. Then, when a command is selected we can expand it vertically to include all shortcuts assigned to that command, and a button for adding new shortcuts. It may also help to group the shortcuts into categories, to make it easier to navigate the list.

Comment 1

[Daniel Brooks [:db48x]]

Attachment: 457648-1.diff

there are a few minor polish-level things to clean up (such as what happens when you remove a key from shortcut then select a different shortcut) but I'd like to get started on the reviews.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava and I talked a while back about the Shortcut Editor. We came to the conclusion that it would not need to be shipped in Fennec, but there could be add-ons to either support a full scale editor or just add-ons to switch hardkeys around for specific phone models.

So I am suggesting we close this bug

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

closing for now