457677 - PlacesUtils ignores dynamic containers

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

Attachment: patch

In placesUtils we are ignoring dynamic containers in 2 places:

- nodeIsReadOnly is checking only for folders, but being a dynamic container a special folder it should check for it too

- nodeIsDynamicContainer is not working at all, since it's using undefined NHRN constant (while there, i've cleaned up remaining code that's using NHRN, all code directly refer to Ci.nsINavHistoryResultNode so there's no point in doing it differently somewhere)

Comment 1

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/47a93d7b43cf

Comment 2

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv