457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

In a normal situation ExcludeReadOnlyFolders is false, in such a case a readonly dynamic container is still excluded by a bogus if condition

-      if (itemType == TYPE_DYNAMIC_CONTAINER ||
-          (itemType == TYPE_FOLDER && options->ExcludeReadOnlyFolders())) {

so a folder containing dynamic containers will result empty

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

with unit test

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 340918 [details] [diff] [review]
patch

r=me

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/77c1ff6133fc

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv