457705 - Use literal Array initializers instead of Kit.semicolonSplit()

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Hannes Wallnoefer]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.3) Gecko/2008092510 Ubuntu/8.04 (hardy) Firefox/3.0.3
Build Identifier: 

Rhino uses org.mozilla.javascript.Kit.semicolonSplit() in order to split strings into string arrays during initialization of error constructors and standard java packages. I guess this goes back to a time when Java didn't support literal array initializers, although I'm not sure - they seem to have been in the Java language specification 1.0 already: http://java.sun.com/docs/books/jls/first_edition/html/10.doc.html#11358. 

Reproducible: Always

Comment 1

[Hannes Wallnoefer]

Attachment: Use array literals instead of Kit.semicolonSplit

Use literal array initializers and dump Kit.semicolonSplit().

Comment 2

[Hannes Wallnoefer]

Attachment: slightly revised patch

No cosmetic changes in ScriptableObject

Comment 3

[Hannes Wallnoefer]

Checking in src/org/mozilla/javascript/Kit.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/Kit.java,v  <--  Kit.java
new revision: 1.26; previous revision: 1.25
done
Checking in src/org/mozilla/javascript/NativeGlobal.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeGlobal.java,v  <--  NativeGlobal.java
new revision: 1.83; previous revision: 1.82
done
Checking in src/org/mozilla/javascript/NativeJavaPackage.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeJavaPackage.java,v  <--  NativeJavaPackage.java
new revision: 1.44; previous revision: 1.43
done
Checking in src/org/mozilla/javascript/NativeJavaTopPackage.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeJavaTopPackage.java,v  <--  NativeJavaTopPackage.java
new revision: 1.21; previous revision: 1.20
done