Closed
Bug 457776
Opened 17 years ago
Closed 17 years ago
"ASSERTION: didn't call Disconnect" with XMLHttpRequestUpload.onabort
Categories
(Core :: XML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: smaug)
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
153 bytes,
text/html
|
Details | |
|
1.64 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. Load the testcase.
2. Quit Firefox using Cmd+Q.
Result:
###!!! ASSERTION: didn't call Disconnect: '!mTarget', file /Users/jruderman/central/content/events/src/nsEventListenerManager.cpp, line 353
I think the problem is that mListenerManager is set by nsXHREventTarget, a base class for both nsXMLHttpRequestUpload and nsXMLHttpRequest, but only nsXMLHttpRequest's destructor calls Disconnect. The least disruptive fix would be to make nsXMLHttpRequestUpload's destructor do the same, but it might make more sense to move it to mListenerManager's destructor if that doesn't cause timing issues.
|
Assignee | |
Comment 1•17 years ago
|
||
We want Upload's dtor to do the same thing as XHR's dtor.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #341101 -
Flags: superreview?(jst)
Attachment #341101 -
Flags: review?(jst)
|
||
Updated•17 years ago
|
Attachment #341101 -
Flags: superreview?(jst)
Attachment #341101 -
Flags: superreview+
Attachment #341101 -
Flags: review?(jst)
Attachment #341101 -
Flags: review+
|
Reporter | |
Updated•17 years ago
|
Flags: in-testsuite+
|
|
Reporter | |
Comment 3•17 years ago
|
||
I think Smaug forgot to mark this as FIXED.
Fix:
http://hg.mozilla.org/mozilla-central/rev/a19ab7286802
Crashtest:
http://hg.mozilla.org/mozilla-central/rev/bad67e7ea71b
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•