457784 - Turning autosync_offline_stores pref off doesn't turn auto-sync off for offline INBOXs

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Emre Birol]

Turning mail.server.default.autosync_offline_stores off doesn't turn auto-sync completely off for **offline INBOX** folders. 

When autosync_offline_stores is false, it prevents auto-sync from updating folders and iterating through the existing headers during idle time, but doesn't prevent it from downloading pending messages of offline INBOX folders.
As a result, unless the user sets INBOX not-offline explicitly, auto-sync keeps downloading pending messages behind the scene as they show up on the server. 

This is only true for INBOX folders, auto-sync treats other folders as expected by not downloading their messages.

The root of the problem is the following test statement in nsImapMailFolder::HeaderFetchCompleted:

> if (autoSyncOfflineStores || mFlags & nsMsgFolderFlags::Inbox)

It creates a hole in the logic when the folder is INBOX, and auto-sync patch doesn't closes it.

Comment 1

[Emre Birol]

Attachment: proposed fix 1

We download the message bodies if either autosync_offline_stores or download_bodies_on_get_new_mail is true.

Comment 2

[Emre Birol]

Comment on attachment 341042 [details] [diff] [review]
proposed fix 1

I forgot to ask for sr, doing now.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/5d09d3352afe