457803 - "nsDragService.cpp(146) : warning C4146: unary minus operator applied to unsigned type"

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Serge Gautherie (:sgautherie)]

{
.../widget/src/windows/nsDragService.cpp(146) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
}

Code is:
{
121  PRUint32 bmWidth = dragRect.width, bmHeight = dragRect.height;
...
142  BITMAPV5HEADER bmih;
...
146  bmih.bV5Height      = -bmHeight; // flip vertical
}

Comment 1

[:aceman]

Attachment: patch

Serge, can you try if this fixes it for you?

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 606980 [details] [diff] [review]
patch

(In reply to :aceman from comment #1)
> Serge, can you try if this fixes it for you?

I can't build anymore, but you can Try it:

https://tbpl.mozilla.org/php/getParsedLog.php?id=10171351&tree=Try&full=1
WINNT 5.2 try build on 2012-03-18 17:48:24 PDT for push 76573506d189
{
[...]/widget/windows/nsDragService.cpp(147) : warning C4146: unary minus operator applied to unsigned type, result still unsigned
}

Comment 3

[:aceman]

Comment on attachment 606980 [details] [diff] [review]
patch

Thanks, looks like there is no warning now. Let's poke some reviewer if the change is OK and doesn't change the logic.

Comment 4

[:aceman]

So let's hope it is OK.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3140ea46ca2

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/a3140ea46ca2