457970 - AVG SafeSearch crash: Firefox 3.0.x Crash Reports in [@avgssff.dll@0x9943][@strchr | avgssff.dll@0x5546f]

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect, P2)

Description

[chris hofmann]

pretty sharp increase in the number of crash reports (current ranked #7) around this stack trace.  Very similiar to https://bugzilla.mozilla.org/show_bug.cgi?id=436302 where we blocked older versions of roboform

0  	mozcrt19.dll  	strchr  	strchr.asm:101
1 	avgssff.dll 	avgssff.dll@0x5546f 	
2 	avgssff.dll 	avgssff.dll@0x22092 	
3 	avgssff.dll 	avgssff.dll@0x219f6 	
4 	avgssff.dll 	avgssff.dll@0x21b33 	
5 	xul.dll 	nsFactoryEntry::GetFactory 	mozilla/xpcom/components/nsComponentManager.cpp:3562
6 	xul.dll 	nsComponentManagerImpl::CreateInstance 	mozilla/xpcom/components/nsComponentManager.cpp:1666
7 	xul.dll 	xul.dll@0x7b7eff

(comment: On upgrade firefox will not restart) 

and a few with

0  	mozcrt19.dll  	strchr  	strchr.asm:101
1 	PlainOldFavorites.dll 	PlainOldFavorites.dll@0x4ebf 	
2 	PlainOldFavorites.dll 	PlainOldFavorites.dll@0x1dfb 	

(comment: crashes everytime you close it.)

Comment 1

[Matthias Versen [:Matti]]

FYI: I think a reporter had this problem in bug 457248

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Note: AVG Free's plugin still has this bug... Anyone have a contact?

Rewording title to make it more correct

Workaround is to restart in safe mode, disable AVG SafeSearch, then quit and restart normally.

Comment 4

[Samuel Sidler (old account; do not CC)]

Rey: Does anyone on that add-ons team have a contact here? (I don't, personally.)

Comment 5

[Jesse Ruderman]

#44 crash for Firefox 3.5.2.

Comment 6

[Jesse Ruderman on Windows]

Kev, do you have an AVG SafeSearch contact?

Anyone know whether this still happens with the current version of AVG SafeSearch?  If not, blocklisting the older versions might be appropriate.

Comment 7

[Damon Sicore (:damons)]

Added bug 523876 specifically for vendor outreach to AVG.

Comment 8

[Greg Mosher]

Looking at that bug it appears to be related to a strchr problem  
that was showing up in avgssff.dll version 8.0.0.148 and prior.   
This is over a year old and I would say we do not have a problem  
with you blocking any AVG SafeSearch that has a version of "8.0".   
Can you provide any more details on what the current crashes are.   
Are they still from the "8.0" or are you seeing "8.5" or "9.0"?

Comment 9

[Justin Dolske [:Dolske]]

It looks like this problem has mostly gone away...

In the past 2 weeks on all FF versions, there are only 79 signatures matching "strchr | avgssff.dll@0x5546f". [It's possible there are more -- the same query shows an additional 2427 crashes at just "strchr"... But skimming though a few of those indicates that (1) the stacks are broken, so I can't see what called strchr and (2) avgssff.dll isn't present in the modules list anyway.]

For the [@strchr | avgssff.dll@0x5546f] crashes, the module list indicates the majority are avgssff.dll version 8.0.0.148 (with a handful of other 8.0.0.* versions).

So, the blocklisting we're doing in bug 519340 should take care of this too.

Comment 10

[Justin Dolske [:Dolske]]

Calling this fixed, any further work would be in new bugs at this point.