457972 - Delete redundant type checks in DOMClassInfo

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jason Orendorff [:jorendorff]]

nsLocationSH::PreCreate and nsNavigatorSH::PreCreate unnecessarily QI, checking to make sure the given object is actually of the right type.  But this can't happen anymore.

There are other places where QI calls could be casts as well.

nsNavigatorSH::PreCreate says:

  nsCOMPtr<nsIDOMNavigator> safeNav(do_QueryInterface(nativeObj));
  if (!safeNav) {
    // Oops, this wasn't really a navigator object. This can happen if someone
    // tries to use our scriptable helper as a real object and tries to wrap
    // it, see bug 319296.
    return NS_OK;
  }

The comment is wrong.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This code is long gone, with Navigator and Location moved to WebIDL.