457977 - Entering any data in "Tags" field in bookmark causes "Name" field contents to not render

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

If a user has a bookmark, edits it, and puts anything in the "Tags" field, when the user opens the bookmark later, the title will be blank in the bookmark properties. If the contents of the Tags field are removed and the bookmark saved, if the user edits the bookmark again, the contents of the Name field return as before. This suggests that the data is not going away but that the contents of the Title field simply don't render when editing bookmarks if the Tags field contains data.

Steps to Reproduce
1. Start Fennec
2. On default home page, select the Star button in the right pane to bookmark the page.
3. Select the Star button again to edit the bookmark.

Note the title

4. Enter 'x' in the Tags field and select "Done" to save the bookmark.
5. Select the Star button again to edit the bookmark.

Result: Bookmark has no title in the UI for editing bookmarks.

6. Remove the contents of the Tags field.
7. Select the Star button again.

Result: Title returns in bookmark properties.

This was found with John O'Duinn's build from 9/30.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Cleanup some problems with bookmark and starring

In fixing this bug, I found some others which may or may not be filed:
* adding tag males title disappear (this bug) - We weren't using the right method of getting correct itemId for the bookmark. We have to skip any tag items referring to the uri. We now match firefox. In fact, we are using the same PlacesUtils code module.
* Removing a bookmark, then adding it again loaded the previous data
* Removing a bookmark left the 'star' in the wrong state

These are fixed

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/ae18f794abf9

Comment 3

[Al Billings [:abillings - ex-MoCo]]

Verified.