Last Comment Bug 457980 - hundreds of kilobytes of useless strings in libPKIX
: hundreds of kilobytes of useless strings in libPKIX
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.12
: All All
: -- normal (vote)
: 3.12.2
Assigned To: Nelson Bolyard (seldom reads bugmail)
:
Mentors:
Depends on:
Blocks: 400915
  Show dependency treegraph
 
Reported: 2008-09-30 19:40 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2008-11-03 19:40 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (670 bytes, patch)
2008-10-01 11:19 PDT, Nelson Bolyard (seldom reads bugmail)
alvolkov.bgs: review+
Details | Diff | Review

Description Nelson Bolyard (seldom reads bugmail) 2008-09-30 19:40:01 PDT
In nss/lib/libpkix/pkix/util/pkix_tools.h at about line 330, we see:

330 /* disable to disable ;-) */
331 #define WANT_TRACE_CHECK_FAILURES

With that symbol defined, HUGE numbers of strings are found in nss3.dll.
With that symbol undefined (by commenting out the above line), the size
of DEBUG builds of nss3.dll is reduced by hundreds of kilobytes. 

So, I want that symbol to be undefined by default ASAP.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2008-10-01 11:19:07 PDT
Created attachment 341308 [details] [diff] [review]
patch

Alexei, please review
Comment 2 Alexei Volkov 2008-10-06 11:51:52 PDT
Comment on attachment 341308 [details] [diff] [review]
patch

r=alexei
Comment 3 Nelson Bolyard (seldom reads bugmail) 2008-10-06 16:17:37 PDT
libpkix/pkix/util/pkix_tools.h; new revision: 1.21; previous revision: 1.20

Thanks for the review, Alexei

Note You need to log in before you can comment on or make changes to this bug.