Closed
Bug 457980
Opened 16 years ago
Closed 16 years ago
hundreds of kilobytes of useless strings in libPKIX
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.2
People
(Reporter: nelson, Assigned: nelson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
670 bytes,
patch
|
alvolkov.bgs
:
review+
|
Details | Diff | Splinter Review |
In nss/lib/libpkix/pkix/util/pkix_tools.h at about line 330, we see:
330 /* disable to disable ;-) */
331 #define WANT_TRACE_CHECK_FAILURES
With that symbol defined, HUGE numbers of strings are found in nss3.dll.
With that symbol undefined (by commenting out the above line), the size
of DEBUG builds of nss3.dll is reduced by hundreds of kilobytes.
So, I want that symbol to be undefined by default ASAP.
|
Assignee | |
Updated•16 years ago
|
Summary: hundreds of useless kilobytes of strings in libPKIX → hundreds of kilobytes of useless strings in libPKIX
|
|
Assignee | |
Comment 1•16 years ago
|
||
Alexei, please review
Assignee: alexei.volkov.bugs → nelson
Status: NEW → ASSIGNED
Attachment #341308 -
Flags: review?(alexei.volkov.bugs)
|
||
Updated•16 years ago
|
Attachment #341308 -
Flags: review?(alexei.volkov.bugs) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 341308 [details] [diff] [review]
patch
r=alexei
|
|
Assignee | |
Comment 3•16 years ago
|
||
libpkix/pkix/util/pkix_tools.h; new revision: 1.21; previous revision: 1.20
Thanks for the review, Alexei
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12.2
You need to log in
before you can comment on or make changes to this bug.
Description
•