457984 - Enable PKCS11 module logging in optimized builds

Status: RESOLVED FIXED

(NSS :: Build, enhancement, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

The most helpful tool for debugging problems with PKCS#11 modules is 
the PKCS#11 module logging facility in NSS.  Unfortunately, it is presently
only found in debug builds.  So, every time some user in the field has a 
problem, we have to find a way to get that user a debug build to log the 
problems.  This has recently become MUCH more difficult to do on Windows.

So, I propose that we enable the PKCS#11 module logger by default in 
Optimized builds.  This can be done by a very small change to the file
nss/lib/pk11wrap/pk11load.c near line 51, which reads

51 #ifdef DEBUG
52 #define DEBUG_MODULE 1
53 #endif

Simply removing lines 51 and 53 would do.  

Alternatively, changing line 51 to read 

#if defined(DEBUG) || defined(some other symbol)

and then defining that other symbol in the Makefile would also do.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Bob, please review this tiny patch

Comment 2

[Robert Relyea]

Comment on attachment 341311 [details] [diff] [review]
patch v1

r+

I see no problem enabling this debugging even in optimized builds.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2

Sorry, that last patch was necessary but not sufficient.
This patch adds one more line, and really works! :)

Comment 4

[Robert Relyea]

Comment on attachment 341330 [details] [diff] [review]
patch v2

Is this needed for PR_Log if debug isn't defined?

bob

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Bob asked,
> Is this needed for PR_Log if debug isn't defined?

Yes.  Without it, all the debug_module code for PR_Logging is a no-op.
It still computes the statistics, which are output to stdout, but does 
none of the logging.

Comment 6

[Robert Relyea]

Comment on attachment 341330 [details] [diff] [review]
patch v2

r+

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Thanks, Bob,

Checking in pk11load.c; new revision: 1.25; previous revision: 1.24