458062 - "There are no items matching that search" when viewing source files

Status: RESOLVED FIXED

(Webtools Graveyard :: Verbatim, defect)

Description

[Wil Clouser [:clouserw]]

If I click on a file name to edit some strings sometimes I see:


End of batch
There are no items matching that search ('')
Click here to return to the index


http://sm-cms01.mozilla.com:8081/en/languages/en_US/amo/LC_MESSAGES/messages-combined.po?translate=1&view=1 is doing it right now.  It appears to happen randomly and occurs often enough that it's a major bug but I've found no reliable way to reproduce it.  This should probably be fixed before the alpha becomes more widespread.

Comment 1

[Wil Clouser [:clouserw]]

This definitely occurs after a period of time (overnight in my case) and is fixable by restarting pootle.  

It's also inconsistent as far as locales (it works for Basque, not for French)

In the past the overnight bugs were caused by db problems but the length of time it takes to reproduce this makes it particularly difficult to debug.

Comment 2

[Wil Clouser [:clouserw]]

I just pushed a major update.  Since this is hard to reproduce I'd be happy if someone can let me know if they see it.

Comment 3

[Wil Clouser [:clouserw]]

This currently manifests itself in a more obvious way:  All statistics are reported as zero.  If someone clicks far enough down on the site they'll see the "no items matching that search" message too, but it's obvious something is broken before then.

I managed to get this on my dev copy today and also found a bunch of "OperationalError: (2006, 'MySQL server has gone away')" errors in the log.  I don't know why it's not reconnecting but I'm fairly confident that's what the problem is now.

Comment 4

[Wil Clouser [:clouserw]]

I reduced pool_recycle from 3600 to 1200 which appeared to delay this affect for another 24 hours or so but didn't fix it.

I turned on sqlalchemy's echo_pool and mysql's query logging to look at this closer.  if echo_pool is to be believed sqlalchemy's threadpool is working fine; checking connections out and restarting them after $pool_recycle seconds.

However, the query logging tells a different story.  When this bug is not happening and someone loads the front page it does a SELECT for each language's stats as well as a select for each user stat at the bottom of the page.  When this bug is happening, there are no language select queries.  Only the user stat queries are hitting the database.

So...half the queries on the page are working and the others never get to the database.  SQLAlchemy is not making me a happy camper.

Comment 5

[Wil Clouser [:clouserw]]

I removed mysql support from Verbatim and haven't been able to do reproduce this.  It's a performance hit but I don't think we want to add mysql support for a single version of pootle since we're jumping right to django after this.  Especially using our broken sqlalchemy lib.