458111 - Remove Mac-specific tabbrowser-tab binding

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

this applies after bug 438302

Comment 2

[Markus Stange [:mstange]]

This patch has some minor alignment problems. When selecting a previously unselected tab
 - the favicon shifts 1px to the left,
 - the close button 1px to the right and
 - the text 1px to the bottom.

And as much as I love that you're simplifying the code by removing images, now the tabs unfortunately look much less crisp. Especially the rounded corners of the selected tab have become really blurry.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch v2

padding of the selected tab fixed

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #2)
> And as much as I love that you're simplifying the code by removing images, now
> the tabs unfortunately look much less crisp. Especially the rounded corners of
> the selected tab have become really blurry.

This seems rather minor to me and is hardly noticeable unless you pay scrupulous attention to it. Even then I only see the difference in the selected tab's corners.

I don't think that should prevent us from getting rid of that bloated binding and messy CSS (the negative margins in particular have undesirable side effects).

That said, it should be possible to improve this with border-image.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch v2

that was actually too much padding

Comment 6

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 341619 [details] [diff] [review]
patch v2

Looks good. We can investigate adding some border-image or box-shadow love in a followup.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3c972117c09e

Comment 8

[Dão Gottwald [:dao]]

> it should be possible to improve this with border-image.

filed bug 462498