458113 - OS/2 build breaks after Implementation of user font set object

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1b1pre) Gecko/20080930011334 Minefield/3.1b1pre
Build Identifier: 

E:/usr/src/hg/comm-central/mozilla/gfx/thebes/src/gfxPlatform.cpp
In file included from E:/usr/src/hg/comm-central/mozilla/gfx/thebes/src/gfxPlatform.cpp:52:
../../../dist/include/thebes/gfxOS2Platform.h:75: error: expected `,' or `...' before "gfxUserFontSet"
../../../dist/include/thebes/gfxPlatform.h:192: warning: `virtual gfxFontGroup* gfxPlatform::CreateFontGroup(const nsAString_internal&, const gfxFontStyle*, gfxUserFontSet*)' was hidden
../../../dist/include/thebes/gfxOS2Platform.h:75: warning:   by `gfxFontGroup* gfxOS2Platform::CreateFontGroup(const nsAString_internal&, const gfxFontStyle*)'
E:/usr/src/hg/comm-central/mozilla/gfx/thebes/src/gfxPlatform.cpp: In static member function `static nsresult gfxPlatform::Init()':
E:/usr/src/hg/comm-central/mozilla/gfx/thebes/src/gfxPlatform.cpp:180: error: cannot allocate an object of type `gfxOS2Platform'
E:/usr/src/hg/comm-central/mozilla/gfx/thebes/src/gfxPlatform.cpp:180: error:   because the following virtual functions are abstract:
../../../dist/include/thebes/gfxPlatform.h:192: error:  virtual gfxFontGroup* gfxPlatform::CreateFontGroup(const nsAString_internal&, const gfxFontStyle*, gfxUserFontSet*)
make.exe[6]: *** [gfxPlatform.o] Error 1
hm, just wanted to test Paul's new gcc-3.4.6 build, but...

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[John Daggett (:jtd)]

Attachment: patch, possible fix

Argh, malformed method declaration.  Let me know if there's something else that breaks.

Comment 2

[Walter Meinl]

Comment on attachment 341411 [details] [diff] [review]
patch, possible fix

John, you're right, the patch is fixing the problem. Firefox is building and running again on OS/2. Looking at your checkin for bug441473 it was by accident the only gfx*Platform.h file where you missed the comma. I could have seen it earlier, the compiler said it already ;-)
I don't have permission to check it in, could you do it then? thanks

Comment 3

[Peter Weilbacher]

Comment on attachment 341411 [details] [diff] [review]
patch, possible fix

No need to sr OS/2 code.

Comment 4

[Peter Weilbacher]

Tinderboxes open and me being available never seems to coincide any more, so would be great if somebody else could check in this OS/2 only build break fix.