Closed Bug 458132 Opened 12 years ago Closed 10 years ago

Frequent hangs in CalculateFrecencyInterval when viewing webcam

Categories

(Toolkit :: Places, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: joe, Unassigned)

References

()

Details

(Keywords: perf, Whiteboard: [TSnappiness])

Visit the URL mentioned. Watch for a bit. You'll notice pretty frequent ~1s hangs (at least on my system, they're about 1s) where no events are being processed by Firefox. Breaking into the process at this point reveals the following stack:

#0	0x1216d9b6 in sqlite3VdbeExec at sqlite3.c:40154
#1	0x12168acc in sqlite3Step at sqlite3.c:37014
#2	0x12168dab in sqlite3_step at sqlite3.c:37079
#3	0x120fd7c8 in mozStorageStatement::ExecuteStep at mozStorageStatement.cpp:541
#4	0x13e2606e in nsNavHistory::CalculateFrecencyInternal at nsNavHistory.cpp:6348
#5	0x13e2847d in nsNavHistory::UpdateFrecency at nsNavHistory.cpp:6294
#6	0x13e3bad2 in nsNavHistory::AddVisit at nsNavHistory.cpp:2607
#7	0x13e29057 in nsNavHistory::AddVisitChain at nsNavHistory.cpp:4412
#8	0x13e2b169 in nsNavHistory::AddURIInternal at nsNavHistory.cpp:4255
#9	0x13e394fa in nsNavHistory::CommitLazyMessages at nsNavHistory.cpp:4837
#10	0x13e395d1 in nsNavHistory::LazyTimerCallback at nsNavHistory.cpp:4823
#11	0x0045edee in nsTimerImpl::Fire at nsTimerImpl.cpp:420
#12	0x0045f026 in nsTimerEvent::Run at nsTimerImpl.cpp:512
#13	0x00458480 in nsThread::ProcessNextEvent at nsThread.cpp:510
#14	0x003e1df4 in NS_ProcessPendingEvents_P at nsThreadUtils.cpp:180
#15	0x09879013 in nsBaseAppShell::NativeEventCallback at nsBaseAppShell.cpp:121
#16	0x09832c1a in nsAppShell::ProcessGeckoEvents at nsAppShell.mm:302

Now, I believe that we're probably getting a lot of load events, since in bug 455606 comment 7, Boris says that the nsImageDocument creates a channel per frame, more or less.
Product: Firefox → Toolkit
QA Contact: places → places
Version: unspecified → Trunk
this could be better now with fsync stuff, those should be added to the memory table
Whiteboard: [TSnappiness]
after bug 556631 this should not be a issue anymore.
Status: NEW → RESOLVED
Closed: 10 years ago
Depends on: 556631
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.