458149 - Clean up style problems in PreferenceManager

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Chris Lawson (gone)]

+++ This bug was initially created as a clone of Bug #437552 +++

There's a ton of whitespace on blank lines in PreferenceManager.mm, along with other assorted style issues. As soon as we get to a reasonably stable point (read: when we don't have pending bugs touching this code), we should fix it.

Comment 1

[Chris Lawson (gone)]

Attachment: style fix v1.0

This should do it. At least I won't be rotting myself, anyway.

Comment 2

[Jeff Dlouhy]

Comment on attachment 352252 [details] [diff] [review]
style fix v1.0

M-x delete-trailing-whitespace

Looks good to me.

r=me

Comment 3

[Stuart Morgan]

Comment on attachment 352252 [details] [diff] [review]
style fix v1.0

>-// settings are done by WebFeatures and stylesheet loading is done by PreferenceManager
>+// settings are done by Web Features and stylesheet loading is done by the preference manager.

Undo this change. Referring to the classes is more useful, and violates no rules of the English language.

sr=smorgan

Comment 4

[Chris Lawson (gone)]

Attachment: fix v1.01

For checkin, puts the class names back (but still adds the period at the end of the sentence).

Comment 5

[Chris Lawson (gone)]

Since this has sr and bug 407883 hasn't even gotten r+ yet (hendy promised to do it soon), let's go ahead and get this landed and I'll un-rot the other patch as needed.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk.