458173 - Focus completely busted with Ctrl+Tab.

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Johnny Stenback (:jst)]

As of a few days ago (from what I can tell, w/o having had the time to download builds and test etc), when you hit Ctrl+Tab in Firefox, the window that opens up and shows the tabs does not have focus, and the you either need to Alt+Tab to the firefox window, or use the mouse to focus the window to be able to switch tabs.

This IMO must block beta1 (why is there no blocking beta1 flag in bugzilla?), makes using tabs in Firefox extremely hard.

Comment 1

[Dão Gottwald [:dao]]

I think this is a regression from bug 451300.

Comment 2

[Dão Gottwald [:dao]]

More precisely, the change in bug 451300 comment 22.

Comment 3

[Damian Shaw [Quan]]

Sounds like it could be a Linux thing.

WFM on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1b1pre) Gecko/20081001 Minefield/3.1b1pre ID:20081001053411

Comment 4

[Dão Gottwald [:dao]]

For some reason I can't get the chrome test on Linux to fail with noautohide="true", although it's clearly broken when I press Ctrl+Tab manually. I tried to delay the tests as the panel widget is created asynchronously, but the tests passed nonetheless.

Comment 5

[Rob Arnold [:robarnold]]

Is there any way to make the change windows-only like we do with browser-aero.css?

Comment 6

[Dão Gottwald [:dao]]

We could ifdef the attribute, although eventually we shouldn't use it on Windows either.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> eventually we shouldn't use it on Windows either.

which I guess depends on bug 457997...

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Can we back out the change from bug 451300 for beta 1 as to unbreak this for that milestone and then work it out afterwards?

Comment 9

[Dão Gottwald [:dao]]

Attachment: use the offending attribute only on Windows

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/184ad4f909cd

Comment 11

[Tracy Walker [:tracy]]

verified with:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20081003 Minefield/3.1b1pre