Closed
Bug 458256
Opened 16 years ago
Closed 16 years ago
InitializeFontEmbeddingProcs uses LoadLibrary -- should be wide
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: jtd)
Details
Attachments
(1 file, 1 obsolete file)
|
755 bytes,
patch
|
vlad
:
review+
vlad
:
superreview+
|
Details | Diff | Splinter Review |
We should use LoadLibraryW where possible.
Attachment #341480 -
Flags: review?(pavlov)
|
Assignee | |
Comment 1•16 years ago
|
||
Doug, why exactly is LoadLibraryW important here? Just curious...
|
Reporter | |
Comment 2•16 years ago
|
||
windows mobile doesn't have LoadLibrary -- plus we are trying to make Firefox only use wide functions were possible.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #341480 -
Flags: superreview?(vladimir)
Attachment #341480 -
Flags: review?(vladimir)
Attachment #341480 -
Flags: review?(pavlov)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 341480 [details] [diff] [review]
patch v.1
simple change in load library call used
Attachment #341480 -
Flags: superreview?(vladimir)
Attachment #341480 -
Flags: superreview+
Attachment #341480 -
Flags: review?(vladimir)
Attachment #341480 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Same as the last patch plus use a different time call on WinCE.
Assignee: doug.turner → jdaggett
Attachment #341480 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #343147 -
Flags: superreview?(vladimir)
Attachment #343147 -
Flags: review?(vladimir)
Attachment #343147 -
Flags: superreview?(vladimir)
Attachment #343147 -
Flags: superreview+
Attachment #343147 -
Flags: review?(vladimir)
Attachment #343147 -
Flags: review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Checked in (Changeset fedc5539b3cf685fb9a8e45ae2a936a27d4c7650)
A sepearate patch related to VC7.1 support trimmed out the use of time() so only the LoadLibrary change was applied.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → Core Graveyard
|
|
Assignee | |
Updated•16 years ago
|
Component: GFX: Win32 → GFX: Thebes
Product: Core Graveyard → Core
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•