Closed Bug 458256 Opened 16 years ago Closed 16 years ago

InitializeFontEmbeddingProcs uses LoadLibrary -- should be wide

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: jtd)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch v.1 (obsolete) — Splinter Review
We should use LoadLibraryW where possible.
Attachment #341480 - Flags: review?(pavlov)
Doug, why exactly is LoadLibraryW important here?  Just curious...
windows mobile doesn't have LoadLibrary -- plus we are trying to make Firefox only use wide functions were possible.
Attachment #341480 - Flags: superreview?(vladimir)
Attachment #341480 - Flags: review?(vladimir)
Attachment #341480 - Flags: review?(pavlov)
Comment on attachment 341480 [details] [diff] [review]
patch v.1

simple change in load library call used
Attachment #341480 - Flags: superreview?(vladimir)
Attachment #341480 - Flags: superreview+
Attachment #341480 - Flags: review?(vladimir)
Attachment #341480 - Flags: review+
Same as the last patch plus use a different time call on WinCE.
Assignee: doug.turner → jdaggett
Attachment #341480 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #343147 - Flags: superreview?(vladimir)
Attachment #343147 - Flags: review?(vladimir)
Attachment #343147 - Flags: superreview?(vladimir)
Attachment #343147 - Flags: superreview+
Attachment #343147 - Flags: review?(vladimir)
Attachment #343147 - Flags: review+
Checked in (Changeset fedc5539b3cf685fb9a8e45ae2a936a27d4c7650)

A sepearate patch related to VC7.1 support trimmed out the use of time() so only the LoadLibrary change was applied.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: GFX: Win32 → GFX: Thebes
Product: Core Graveyard → Core
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: