458281 - MOPS opcodes need acceptance tests

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Steven Johnson]

The fast memory-access opcodes added in https://bugzilla.mozilla.org/show_bug.cgi?id=458277 don't yet have acceptance tests in the standard suite, as the standard asc.jar tool doesn't yet support them.

Comment 1

[Steven Johnson]

Note, we have (for now) added a binary-only test to test/acceptance/mops/mops.abc, in the user branch http://hg.mozilla.org/users/stejohns_adobe.com/tamarin-mops/

Comment 2

[Brent Baker]

Is the source code available for the binary file? I know that there is no public compiler, but having access to the AS source will be useful generating new testcases.

Comment 3

[Steven Johnson]

I'm not sure. You should contact Scott Petersen to find out.

Comment 4

[Tom Harwood]

An abcasm-based test is in TR/TC: test/acceptance/abcasm/mops.abs

Comment 5

[Edwin Smith]

are these enough to close the bug or unblock the apr release?

Comment 6

[Tom Harwood]

For basic acceptance tests, I think mops.abs is sufficient.  The tests do a little self-checking to ensure the backing memory picture is consistent, e.g., store two words with hex bit patterns, load the dword as a floating-point value and check the expected result.