Closed Bug 458360 Opened 11 years ago Closed 11 years ago

Qt build breaks after implementation of user font set object

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wildriding, Unassigned)

References

Details

Attachments

(1 file)

Implementation of virtual function gfxPlatform::CreateFontGroup in gfxQtPlatform.cpp is missing parameter "gfxUserFontSet *aUserFontSet". This brakes compilation: 

/gfx/thebes/src/gfxPlatform.cpp: In static member function ‘static nsresult gfxPlatform::Init()’:
/gfx/thebes/src/gfxPlatform.cpp:176: error: cannot allocate an object of abstract type ‘gfxQtPlatform’
../../../dist/include/thebes/gfxQtPlatform.h:51: note:   because the following virtual functions are pure within ‘gfxQtPlatform’:
../../../dist/include/thebes/gfxPlatform.h:192: note: 	virtual gfxFontGroup* gfxPlatform::CreateFontGroup(const nsAString_internal&, const gfxFontStyle*, gfxUserFontSet*)
make[6]: *** [gfxPlatform.o] Error 1
Attached patch patchSplinter Review
Depends on: 441473
Blocks: 441473
No longer depends on: 441473
Attachment #341612 - Flags: review?(neil)
Attachment #341612 - Flags: review?(neil) → review?(vladimir)
Fixed in:
http://hg.mozilla.org/mozilla-central/rev/b222f6e972b3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 449204
No longer blocks: 449204
You need to log in before you can comment on or make changes to this bug.