Closed
Bug 458397
Opened 17 years ago
Closed 17 years ago
Memory leak during TopSite Test on http://www.grono.net
Categories
(Core :: General, defect, P1)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: cbook, Assigned: peterv)
References
()
Details
(Keywords: fixed1.9.1, memory-leak, Whiteboard: [window leak (85 of them)])
Attachments
(3 files)
|
42.17 KB,
text/plain
|
Details | |
|
40.57 KB,
text/plain
|
Details | |
|
1.89 KB,
patch
|
bent.mozilla
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3pre) Gecko/2008092317
Minefield/3.0.3pre
Found during the automated Global-500 Topsite Test on http://www.grono.net
0 TOTAL 15 2046359 15894236 82932 ( 3544.85 +/- 4885.93) 45854105 42575 ( 1267.17 +/- 3004.70)
nsStringStats
=> mAllocCount: 2030862
=> mReallocCount: 33447
=> mFreeCount: 2026857 -- LEAKED 4005 !!!
=> mShareCount: 222061
=> mAdoptCount: 84390
=> mAdoptFreeCount: 84376 -- LEAKED 14 !!!
|
Reporter | |
Comment 1•17 years ago
|
||
seems this Memory Leak is on 1.9.1 bigger then on 1.9.0
0 TOTAL 39 52263449 17529916 2171241 (24239.31 +/- 0.00) 127384779 1144515 ( 8287.60 +/- 6056.31)
nsTraceRefcntImpl::DumpStatistics: 709 entries
nsStringStats
=> mAllocCount: 423244
=> mReallocCount: 65029
=> mFreeCount: 345432 -- LEAKED 77812 !!!
=> mShareCount: 497903
=> mAdoptCount: 113413
=> mAdoptFreeCount: 113397 -- LEAKED 16 !!!
Assertion failed at c:/work/mozilla/builds/1.9.1-trace-malloc/mozilla/gfx/cairo/cairo/src/cairo-hash.c:199: hash_table->live_entries == 0
http://www.grono.net: EXIT STATUS: NORMAL (754.041000 seconds)
|
|
Reporter | |
Comment 2•17 years ago
|
||
requesting blocking because of the results with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081030 Minefield/3.1b2pre, see comment#1
Flags: blocking1.9.1?
|
||
Updated•17 years ago
|
Whiteboard: [window leak]
|
|
||
Updated•17 years ago
|
Whiteboard: [window leak] → [window leak (85 if them)]
|
|
||
Updated•17 years ago
|
Whiteboard: [window leak (85 if them)] → [window leak (85 of them)]
|
|
||
Comment 3•17 years ago
|
||
Leaks 85 windows, blocking.
Assignee: nobody → bent.mozilla
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
|
Assignee | |
Comment 4•17 years ago
|
||
Stealing from bent.
Assignee: bent.mozilla → peterv
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1
Version: 1.9.0 Branch → Trunk
|
|
Assignee | |
Comment 5•17 years ago
|
||
Didn't add unlinking for now, mContent is used in a bunch of places without null-checking.
Attachment #349397 -
Flags: superreview?(jst)
Attachment #349397 -
Flags: review?(bent.mozilla)
|
|
Assignee | |
Comment 6•17 years ago
|
||
BTW, this fixes the leak on http://www.grono.net/. Not sure if it fixes all leaks on other pages, so Tomcat will need to retest after this lands.
Comment on attachment 349397 [details] [diff] [review]
v1
Yay!
(Feel free to steal any and all of my leak bugs!)
Attachment #349397 -
Flags: review?(bent.mozilla) → review+
|
|
||
Updated•17 years ago
|
Attachment #349397 -
Flags: superreview?(jst) → superreview+
|
||
Comment 8•17 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.1b3
|
||
Updated•17 years ago
|
Keywords: fixed1.9.1
|
|
Reporter | |
Updated•17 years ago
|
Blocks: sisyphus-tracking
No longer depends on: sisyphus-tracking
You need to log in
before you can comment on or make changes to this bug.
Description
•