Allow standard global select fields to control visibility of custom fields

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Bugzilla-General
--
enhancement
RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

Bugzilla 3.4
Dependency tree / graph
Bug Flags:
approval +
testcase ?

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Now that we have bug 291433 (the ability for custom fields to control each others' visibility), we should allow some of our standard fields to also control visibility of fields. 

Ideally, I'd like to do this by making bug/edit.html.tmpl use bug/field.html.tmpl for these standard fields, like the Product and Component fields. I'd also like to set them as FIELD_TYPE_SINGLE_SELECT in the database, and make Bugzilla::Field::Choice return the right type of subclasses for each of them (Bugzilla::Product, Bugzilla::Component, etc.), though that may be tricky and may require some work in blockers before we can do it.
(Assignee)

Updated

10 years ago
Depends on: 459064
(Assignee)

Comment 1

10 years ago
Okay, I've got this working for all the normal select fields.
Summary: Allow certain normal fields to control visibility of custom fields → Allow standard global select fields to control visibility of custom fields
(Assignee)

Comment 2

10 years ago
Created attachment 342285 [details] [diff] [review]
v1

This allows all the standard "enum" fields to control the visibility of other fields.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #342285 - Flags: review?(bbaetz)
(Assignee)

Comment 3

10 years ago
Created attachment 342387 [details] [diff] [review]
v2

Oops, I'd forgotten to also modify enter_bug.cgi.
Attachment #342285 - Attachment is obsolete: true
Attachment #342387 - Flags: review?(bbaetz)
Attachment #342285 - Flags: review?(bbaetz)

Updated

10 years ago
Attachment #342387 - Flags: review?(bbaetz) → review+
Comment on attachment 342387 [details] [diff] [review]
v2

The js comment from the other bug applies, but I assume that that will be fixed there

r=bbaetz apart from that
(Assignee)

Comment 5

10 years ago
Putting in the approval queue until the blocker is ready.
Flags: approval?
Target Milestone: Bugzilla 4.0 → Bugzilla 3.4
(Assignee)

Updated

10 years ago
Flags: approval? → approval+
(Assignee)

Comment 6

10 years ago
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/admin/custom_fields/cf-js.js.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/cf-js.js.tmpl,v  <--  cf-js.js.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/custom_fields/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/admin/custom_fields/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.136; previous revision: 1.135
done
Checking in template/en/default/bug/field.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl,v  <--  field.html.tmpl
new revision: 1.20; previous revision: 1.19
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--  knob.html.tmpl
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.89; previous revision: 1.88
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Blocks: 371995

Updated

9 years ago
Flags: testcase?

Updated

5 years ago
Blocks: 275573
You need to log in before you can comment on or make changes to this bug.