458436 - Allow standard global select fields to control visibility of custom fields

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Now that we have bug 291433 (the ability for custom fields to control each others' visibility), we should allow some of our standard fields to also control visibility of fields. 

Ideally, I'd like to do this by making bug/edit.html.tmpl use bug/field.html.tmpl for these standard fields, like the Product and Component fields. I'd also like to set them as FIELD_TYPE_SINGLE_SELECT in the database, and make Bugzilla::Field::Choice return the right type of subclasses for each of them (Bugzilla::Product, Bugzilla::Component, etc.), though that may be tricky and may require some work in blockers before we can do it.

Comment 1

[Max Kanat-Alexander]

Okay, I've got this working for all the normal select fields.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

This allows all the standard "enum" fields to control the visibility of other fields.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Oops, I'd forgotten to also modify enter_bug.cgi.

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 342387 [details] [diff] [review]
v2

The js comment from the other bug applies, but I assume that that will be fixed there

r=bbaetz apart from that

Comment 5

[Max Kanat-Alexander]

Putting in the approval queue until the blocker is ready.

Comment 6

[Max Kanat-Alexander]

Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/admin/custom_fields/cf-js.js.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/cf-js.js.tmpl,v  <--  cf-js.js.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/custom_fields/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/admin/custom_fields/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.136; previous revision: 1.135
done
Checking in template/en/default/bug/field.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl,v  <--  field.html.tmpl
new revision: 1.20; previous revision: 1.19
done
Checking in template/en/default/bug/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/knob.html.tmpl,v  <--  knob.html.tmpl
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.89; previous revision: 1.88
done