458440 - Tp crashes after speculative parsing landing

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I should have filed this bug a long time ago. When the speculative parsing patch landed, we started crashing randomly on Tp on all platforms.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

jst implicitly OK'd this patch in person.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Also note: moving the assignment of mNumConsumed out of the lock is OK because we only look at mNumConsumed on the main thread in nsSpeculativeScriptThread::StartParsing and that asserts that the thread is already idle.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Update

jst, you already looked through this with me, just getting it in the bug.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Hack

dbaron, I talked with you about this patch a while ago. I'd like to check it in to see if it successfully wallpapers over this crash.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 347421 [details] [diff] [review]
Hack

r+sr=dbaron

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(blocks a blocker)

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/db2dd52d47c1 and http://hg.mozilla.org/mozilla-central/rev/9ac7c363cf78