Tp crashes after speculative parsing landing

RESOLVED FIXED in mozilla1.9.1b2

Status

()

RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.1b2
x86
Linux
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

I should have filed this bug a long time ago. When the speculative parsing patch landed, we started crashing randomly on Tp on all platforms.
Posted patch Proposed fixSplinter Review
jst implicitly OK'd this patch in person.
Attachment #341665 - Flags: superreview+
Attachment #341665 - Flags: review+
Also note: moving the assignment of mNumConsumed out of the lock is OK because we only look at mNumConsumed on the main thread in nsSpeculativeScriptThread::StartParsing and that asserts that the thread is already idle.
Posted patch UpdateSplinter Review
jst, you already looked through this with me, just getting it in the bug.
Attachment #347420 - Flags: superreview?(jst)
Attachment #347420 - Flags: review?(jst)
Posted patch HackSplinter Review
dbaron, I talked with you about this patch a while ago. I'd like to check it in to see if it successfully wallpapers over this crash.
Attachment #347421 - Flags: superreview?
Attachment #347421 - Flags: review?
Attachment #347421 - Flags: superreview?(dbaron)
Attachment #347421 - Flags: superreview?
Attachment #347421 - Flags: review?(dbaron)
Attachment #347421 - Flags: review?
Attachment #347420 - Flags: superreview?(jst)
Attachment #347420 - Flags: superreview+
Attachment #347420 - Flags: review?(jst)
Attachment #347420 - Flags: review+
(blocks a blocker)
Flags: blocking1.9.1+
Target Milestone: --- → mozilla1.9.1b2
http://hg.mozilla.org/mozilla-central/rev/db2dd52d47c1 and http://hg.mozilla.org/mozilla-central/rev/9ac7c363cf78
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Keywords: fixed1.9.1

Updated

7 years ago
Depends on: 795547

Updated

7 years ago
No longer depends on: 795547
You need to log in before you can comment on or make changes to this bug.