458527 - recently closed pages not tracked until history menu is accessed

Status: RESOLVED FIXED

(Camino Graveyard :: History, defect)

Description

[Ilya Sherman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.4pre) Gecko/2008092900 Camino/2.0a1pre (like Firefox/3.0.4pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.4pre) Gecko/2008092900 Camino/2.0a1pre (like Firefox/3.0.4pre)

The new "Recently Closed Pages" addition to the history menu is not populated until the first time the history menu is accessed (after each launch of Camino).  This is particularly problematic since I usually first access the history menu when I want to recover an accidentally closed tab!

Reproducible: Always

Steps to Reproduce:
1. Relaunch Camino
2. Navigate to some page
3. Close the page
4. Look at your History: no Recently Closed Pages
5. Navigate to some page
6. Close the page
7. Look at your History: Recently Closed Pages exists, and includes the second page you closed (but not the first)

Comment 1

[Stuart Morgan]

Doh! Thanks for noticing this and tracking down what exactly was happening.

Comment 2

[Stuart Morgan]

Attachment: fix

I hadn't realized that this path also happened during the lazy-load of the history source.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 341774 [details] [diff] [review]
fix

sr=pink

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk for Stuart in advance of a1.