458528 - Remove die_with_dignity()

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

While tracking a bug or a crash, I often need to know which function calls which other function, recursively. But die_with_dignity() is really bad to give us this information. I updated it to be a bit more helpful. Tested, works fine (of course when I enabled it, not when commented :) ).

Note that I was tempted to remove Carp::confess($err_msg), which I consider to be useless as the information is already displayed in the browser. But I keep it for now.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 341764 [details] [diff] [review]
patch, v1

No, in fact, we don't even need die_with_dignity.

For command-line scripts, we just need $SIG{__DIE__} = \&Carp::confess, and for CGI scripts, we want $SIG{__DIE__} = \&CGI::Carp::confess.

Comment 2

[Frédéric Buclin]

Attachment: patch, v2

Remove die_with_dignity().

Comment 3

[Max Kanat-Alexander]

Comment on attachment 341781 [details] [diff] [review]
patch, v2

Looks good to me!

Comment 4

[Frédéric Buclin]

tip:

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.69; previous revision: 1.68
done

3.2rc1:

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.65.2.3; previous revision: 1.65.2.2
done