Closed Bug 458589 Opened 14 years ago Closed 14 years ago

Drag and drop ical (.ics) attachments onto calendar icon does nothing

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: maxxmozilla, Assigned: dbo)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20081004 Lightning/1.0pre Shredder/3.0b1pre ID:20081004031302

Drag and drop ical (.ics) attachments onto calendar / tasks icon does nothing.

Reproducible: Always

Steps to Reproduce:
1. Drag and drop ical (.ics) attachment onto calendar / tasks icon.
Actual Results:  
Nothing happens.

Expected Results:  
New event / task creation.

Error: [Exception... "Could not convert JavaScript argument arg 0 [nsIUnicharStreamLoader.init]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: chrome://calendar/content/calendar-dnd-listener.js :: calDNDDrop :: line 324"  data: no]
Source File: chrome://calendar/content/calendar-dnd-listener.js
Line: 326
Keywords: regression
Works for me on Mac.
Keywords: qawanted
I checked this issue on Linux and Windows and I get the exception too.
Confirmed using Lightning 1.0pre (ID: 20081007031722) and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20081007 Shredder/3.0b1pre (ID: 20081007031514).
Could this be related to the landing of the new Drag&Drop API (http://developer.mozilla.org/en/DragDrop/Drag_and_Drop)?
Attached patch fix - v1 (obsolete) — Splinter Review
I can reproduce it now.

It seems to be an incompatible change on trunk.
Assignee: nobody → daniel.boelzle
Attachment #342227 - Flags: review?(mschroeder)
Keywords: qawanted
Attached patch fix - v2Splinter Review
- fixing missing calendar for item, too
Attachment #342227 - Attachment is obsolete: true
Attachment #342230 - Flags: review?(mschroeder)
Attachment #342227 - Flags: review?(mschroeder)
Status: NEW → ASSIGNED
Comment on attachment 342230 [details] [diff] [review]
fix - v2

r=mschroeder
Attachment #342230 - Flags: review?(mschroeder) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a0784e1ef1fc>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
> -> FIXED
I've tried to verify on manually patched latest build but since a few builds drag and drop to calendar / tasks new icons is not allowed and this patch didn't changed it so it's a little hard to verify ;) -> reopening or new bug ?
Christian has set up bug 459641.
Thanks.
I've applied the patch to the latest build with the "classic" calendar toolbar (build 20081008091054) and I still can't verify the fix ?
(bug 459641 would unlock drop action but if this bug is not really fixed then not much would change)

Error: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIChannel.asyncOpen]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://calendar/content/calendar-dnd-listener.js :: calDNDDrop :: line 325"  data: no]
Source File: chrome://calendar/content/calendar-dnd-listener.js
Line: 328
The fix has worked for me on Mac at that time, dragging an iTIP attachment onto the mode buttons. Maybe you're dragging something else? Please give some more details, especially your platform.
I keep this bug open and recheck the fix once bug 459641 is fixed.
Severity: minor → normal
Status: RESOLVED → REOPENED
Depends on: 459641
Flags: blocking-calendar1.0+
Resolution: FIXED → ---
I don't know what kind of problems you had with confirming this bug at the beginning but regarding my comment 11 it was - let's say broken e-mail...

-> Verifying as fixed (if it would be broken after bug 459641 is fixed then it would be a different bug)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081014 Lightning (patched build 20081007031722)/1.0pre Shredder/3.0b1pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081014 Lightning (patched build 20081007032648)/1.0pre Shredder/3.0b1pre
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
No longer depends on: 459641
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
For those interested:
I will not be filing bug against lightning regarding comment 11 error (invite.ics attachment was detached and removed from the file system) because I should be thankful Bug 292385

> Maybe you're dragging something else?
yeah, attachment that isn't there and so NS_ERROR_FILE_NOT_FOUND ;)
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.