458598 - Convert test_notifications.html into a mini-framework for creating notification tests

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[(no longer active)]

One use case here would be writing the private browsing tests in bug 248970.  This is Justin's suggestion in bug 248970 comment 324.

The tests in bug 403420 may be able to use the mini-framework produced here as well, so I'm adding that bug as a dependency as well.

Comment 1

[Justin Dolske [:Dolske]]

Hmm, I'm going to need some of this for the HTTP auth prompt tests, for testing part of bug 394611.

Have you already started this work? If not, I'll go ahead and do it.

Comment 2

[Justin Dolske [:Dolske]]

I went ahead and fixed this in 394611... There's now a notification_common.js with the common functions for getting notification box/bars, and clicking buttons in it.

Comment 3

[(no longer active)]

Can we move the notification_common.js part of the patch for bug 394611 here, now that it's been backed out?  I really need this before I can finish off my work on password manager tests for bug 248970.  I'll attach the appropriate patch which is essentially your work from that bug here.  I'm not sure if it requires another review though.

Comment 4

[(no longer active)]

Attachment: Patch

Part of Dolske's patch in bug 394611.  I'm asking for review here because apparently no review was made on these changes in bug 394611.

Comment 5

[(no longer active)]

Fixed by bug 394611.