458756 - Use raw sqlite3_stmt pointers instead of the mozStorageStatement object for async statements

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Shawn Wilsher :sdwilsh]

We end up doing a lot of work that we don't have to do by wrapping it, and it also means we may not get accurate errors back (due to threading timing issues).  We could add more locks, but we don't need to if we use a raw statement.

We also end up doing less work on the calling thread (addref and release, among other things).

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 2

[Dave Camp (:dcamp)]

Comment on attachment 341979 [details] [diff] [review]
v1.0

>+    // Reset the statement
>+    (void)sqlite3_finalize(mStatement);
>+
>+    // Notify about completion iff we have a callback.

Probably worth nulling out mStatement here.

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> Probably worth nulling out mStatement here.
Fixed locally.  Thanks for the quick review.

Comment 4

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/c98392bd35b3