45876 - Composer Charset coding menu does not put the meta charset info

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Teruko Kobayashi]

This bug is separated from 39780.  

Composer Charset coding menu does not put the meta charset info to
the docuemnt.

Steps of reproduce
1. Open Compser
2. Select View|Charater Coding->Multibyte->Japanese (Shift_JIS)
3. Type Japanese character in Composer
4. Select File|Save As.. to save the file
5. Look at the file from some editor

It saves no charset meta info HTML page with all the Japanse characters written 
out as NCRs.  You cannot see Japanese charscters in the HTML file.

Tested 2000-07-18-10 all platforms.

Comment 1

[Teruko Kobayashi]

From Jan's comment in the 39780, I put [nsbeta2+] in this bug.
------- Additional Comments From [e-mail] 2000-07-17 16:29 -------

Per today's I18n Beta2 QA Status mtg.  All agreed that nsbeta2+ is the way to 
go.  Moving from [nsbeta2-] to [nsbeta2+]

Plus(+)to save user inputted charset at a minimal.

Comment 2

[Frank Tang]

This is tricky. IF the origional page do not have meta tag, when should we add 
one. If we add one right after we load the page, then the document will be dirty 
and we won't be able to change it to other charest. If we add one before we 
"Save" or "Save As...", is that acceptable and where should we remember it ? 
Should we do that part in C++ code or JavaScript code ?

Comment 3

[Kathleen :Brade]

I looked at this bug since I thought I might be able to help.

Frank--if you go in mozilla/editor/ui/composer/content/editor.js
and make EditorSetDocumentCharacterSet look something like below, I think it'll 
fix this bug:

function EditorSetDocumentCharacterSet(aCharset)
{
  if (editorShell)
  {
    editorShell.SetDocumentCharacterSet(aCharset);

    if (!editorShell.documentModified &&
        editorShell.editorDocument.location != "about:blank")
    {
      editorShell.LoadUrl(editorShell.editorDocument.location);
    }
  }
}

Comment 4

[Frank Tang]

thanks kathy. It work :) :) :)
fix check in.

Comment 5

[Teruko Kobayashi]

I tested this in 2000-07-21-08 Win32, Mac and Linux build.  The blank page will
put the meta charset from Composer.  However, the characters are dislayed as NCR 
in the source on only mac build even the meta charset was created.

Comment 6

[Frank Tang]

The problem teruko discover under Mac is a seperate bug. The text of the body is 
correct. The author is not. Mark this fix and teruko will open a seperate bug 
for the other problem.

Comment 7

[Teruko Kobayashi]

I verified this as fixed.

Comment 8

[Daniel Veditz [:dveditz]]

Adding keyword to bugs which already show a nsbeta2 triage value in the status 
whiteboard so the queries don't get screwed up.