Lightning keeps asking for password on startup

RESOLVED FIXED in 1.0b1

Status

Calendar
General
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: davida, Assigned: Fallen)

Tracking

({dogfood})

Trunk
1.0b1
dogfood
Bug Flags:
blocking-calendar1.0 +
tb-integration +

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Even though i have the 'remember password' checkbox saved.  And it seems to save it (the form is prefilled), so the dialog seems pointless

Cc'ing standard8 as I expect the password manager migration will have something to do with this.

(this is for a caldav/zimbra calendar, btw)
Flags: tb-integration+
Flags: blocking-calendar1.0?

Updated

10 years ago
Flags: blocking-calendar1.0? → blocking-calendar1.0+
(Assignee)

Comment 1

10 years ago
Quite annoying to debug, since for me venkman is either crashing or hanging. With gdata this is even worse, I get tons of login dialogs at the same time.
Keywords: dogfood
(Assignee)

Comment 2

10 years ago
Created attachment 343047 [details] [diff] [review]
Fix - v1

This takes care. The problem was that aChannel.URI.port was -1 since it uses the default port in most cases. This patch asks the protocol handler for the default port if no port is given.

For GData, it seems trunk has better concurrency, so lots of login dialogs were shown. Moving this.mLoggingIn takes care.

Also fixes a problem with the command handlers, I had a couple of too much recursion errors on the way.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #343047 - Flags: review?(daniel.boelzle)

Updated

10 years ago
Attachment #343047 - Flags: review?(daniel.boelzle) → review+

Comment 3

10 years ago
Comment on attachment 343047 [details] [diff] [review]
Fix - v1

>+        var port = aChannel.URI.port;
use let instead of var (throughout the patch)

>+        if (port == -1) {
>+            var handler = getIOService().getProtocolHandler(aChannel.URI.scheme)
use cal.getIOService() from calUtils.jsm

looks good; r=dbo
(Assignee)

Comment 4

10 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/e99df1f6bfb8>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
(Assignee)

Comment 5

10 years ago
GData part checked in on HEAD, MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH to ease a possible further branch release of the gdata provider (npotdb).
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.