458911 - buildbot/process/base.py breaks ReleaseTaggingBuilder (because there are too many ShellCommands)

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

Hit this during 3.1b1 - the code that autorenames BuildSteps which are named the same will only do so up to 100 times. We run well over than number of ShellCommands (whose names default to 'shell') during tagging. For the 3.1b1 release I had to locally patch buildbot/process/base.py to up that number to 1000. We need to check in this fix so we don't hit it again.

I've filed an upstream ticket on this bug, too: http://buildbot.net/trac/ticket/366

Comment 1

[[e-mail] (:bhearsum)]

Attachment: [checked in] bump up the maximum step increment in Buildbot

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 342422 [details] [diff] [review]
[checked in] bump up the maximum step increment in Buildbot

Checking in base.py;
/cvsroot/mozilla/tools/buildbot/buildbot/process/base.py,v  <--  base.py
new revision: 1.2; previous revision: 1.1
done