Expose .parameters on function declarations

RESOLVED FIXED

Status

Firefox Build System
Source Code Analysis
RESOLVED FIXED
10 years ago
4 months ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 342102 [details] [diff] [review]
Expose .parameters on function declarations, rev. 1

Expose .parameters on function declarations, which allows me to map parameter names against their doxygen comments.
Attachment #342102 - Flags: review?(tglek)

Comment 1

10 years ago
Comment on attachment 342102 [details] [diff] [review]
Expose .parameters on function declarations, rev. 1


> 
>+      tree args;
>+
>+      if (TREE_CODE(v) == FUNCTION_DECL) {
>+        JSObject *arglist = JS_NewArrayObject (this->cx, 0, NULL);
>+        dehydra_defineProperty (this, obj, "parameters",
>+                                OBJECT_TO_JSVAL (arglist));
>+
>+        tree args; 
                  ^--- looks like a typo(nuke one above). Surprised GCC let that compile

>+        for (args = DECL_ARGUMENTS(v); args; args = TREE_CHAIN (args))
>+          dehydra_addVar(this, args, arglist);
>+      }
>+
Attachment #342102 - Flags: review?(tglek) → review+
(Assignee)

Comment 2

10 years ago
Pushed, http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/2b4111b62343
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.