459018 - 'self.stopEditing is not a function' while creating an event via drag & drop

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect, P1)

Description

[Martin Schröder [:mschroeder]]

I get following error in the Error Console while creating an event in week view via drag'n'drop, but creation of the event works as expected:

Error: self.stopEditing is not a function
Source File: chrome://calendar/content/calendar-view-core.xml
Line: 100

Leaving as unconfirmed because I got this with my own build of Lightning (Windows, comm-central).

Comment 1

[Stefan Sitter [:ssitter]]

I don't see the error using nightly build Lightning 1.0pre (ID: 20081007031722) and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20081007 Shredder/3.0b1pre (ID: 20081007031514).

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

When using a Zimbra CalDAV server, I see this in my own builds, and, worse, the view refreshes itself and puts the "New Event" summary back.  Turns out the edit actually worked, because forcing the calendars to reload themselves causes the correct summary to re-appear.

Comment 3

[Daniel Boelzle [:dbo]]

WFM on Mac, maybe fixed in the meantime?

Comment 4

[Martin Schröder [:mschroeder]]

Confirmed with same error message as in comment#0 using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081121 Lightning/1.0pre Shredder/3.0b1pre.

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

After some investigation, I decided to get rid of using the inputField of textbox directly, and the error message has been gone. I had to remove the focus() call, but select() is enough because it also sets the focus.

After more testing, I decided to restore the full textbox behavior of the event boxes. This means to allow setting the cursor through clicking while inline editing. It works in all views for all day and normal events. The trick was to do some mousethrough-magic in the xul stack that builds the event box.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

While debitrotting the patch, I also had to do some slight modifications to make sure the gripbar is still accessible. This at least doesn't break anything on linux, I can't test this on windows.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3ed4b7db765e>

-> FIXED

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".