Closed Bug 459110 Opened 13 years ago Closed 13 years ago

remove open, close, read and write from wince shunt

Categories

(Core :: General, defect)

x86
Windows CE
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
this patch is directly from mq, if you want more context, let me know
Attachment #343059 - Flags: review?(doug.turner)
Comment on attachment 343059 [details] [diff] [review]
removes broken impl of open, close, read and write from shunt

what do you think about just removing code hidden in the REALLY_REALY_HACKY_FILE_IO
 define?

lets just remove code in the #ifdef 0.  version control helps us find what we removed if need be.


 
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+

4?


Lets get a seperate patch for dbm.  We do not _use_ dbm in our windows mobile build, but it has to compile.
Attachment #343059 - Flags: review?(doug.turner) → review-
again, directly from mq, let me know if you need more context
Attachment #343059 - Attachment is obsolete: true
Attachment #343160 - Flags: review?(doug.turner)
Comment on attachment 343160 [details] [diff] [review]
just the shunt stuff now

what is the flag string stuff used for?
its used in the patch of dbm converting from posix file access to ansii. Its actually a more correct implementation of flags2binstr in the same file.

http://mxr.mozilla.org/mozilla-central/source/build/wince/shunt/stdio.cpp#215

But, I've got another patch to just stop us from building dbm on wince, so this might not actually be needed if we go that route.
so, i am happy to remove stuff from the shunt, but lets not add new stuff if we don't have to.

1) if we check this in, do things continue to build (assuming yes)
   a) what is the likelyhood that fixing DBM to use ansii is going to happen?

2) can we remove the flag to string stuff?
(In reply to comment #6)
> so, i am happy to remove stuff from the shunt, but lets not add new stuff if we
> don't have to.
> 
> 1) if we check this in, do things continue to build (assuming yes)
>    a) what is the likelyhood that fixing DBM to use ansii is going to happen?

Everything builds except dbm, which we don't need to build.  We can also switch to using ansii in dbm, but I think that's a harder hill to climb.

> 
> 2) can we remove the flag to string stuff?

Yea, its just needed to fix dbm.  I'd suggest using the impl in flags2binstr  though.
Comment on attachment 343160 [details] [diff] [review]
just the shunt stuff now

yes, lets remove open and friends.  it isn't implemented correctly now.
Attachment #343160 - Flags: review?(doug.turner) → review+
this patch appears to have been already pushed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
should this be landed on 1.9.1?
You need to log in before you can comment on or make changes to this bug.