459110 - remove open, close, read and write from wince shunt

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: removes broken impl of open, close, read and write from shunt

this patch is directly from mq, if you want more context, let me know

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 343059 [details] [diff] [review]
removes broken impl of open, close, read and write from shunt

what do you think about just removing code hidden in the REALLY_REALY_HACKY_FILE_IO
 define?

lets just remove code in the #ifdef 0.  version control helps us find what we removed if need be.


 
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+
+#ifdef REALLY_REALLY_HACKY_FILE_IO
+

4?


Lets get a seperate patch for dbm.  We do not _use_ dbm in our windows mobile build, but it has to compile.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: just the shunt stuff now

again, directly from mq, let me know if you need more context

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 343160 [details] [diff] [review]
just the shunt stuff now

what is the flag string stuff used for?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

its used in the patch of dbm converting from posix file access to ansii. Its actually a more correct implementation of flags2binstr in the same file.

http://mxr.mozilla.org/mozilla-central/source/build/wince/shunt/stdio.cpp#215

But, I've got another patch to just stop us from building dbm on wince, so this might not actually be needed if we go that route.

Comment 6

[Doug Turner (:dougt)]

so, i am happy to remove stuff from the shunt, but lets not add new stuff if we don't have to.

1) if we check this in, do things continue to build (assuming yes)
   a) what is the likelyhood that fixing DBM to use ansii is going to happen?

2) can we remove the flag to string stuff?

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #6)
> so, i am happy to remove stuff from the shunt, but lets not add new stuff if we
> don't have to.
> 
> 1) if we check this in, do things continue to build (assuming yes)
>    a) what is the likelyhood that fixing DBM to use ansii is going to happen?

Everything builds except dbm, which we don't need to build.  We can also switch to using ansii in dbm, but I think that's a harder hill to climb.

> 
> 2) can we remove the flag to string stuff?

Yea, its just needed to fix dbm.  I'd suggest using the impl in flags2binstr  though.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 343160 [details] [diff] [review]
just the shunt stuff now

yes, lets remove open and friends.  it isn't implemented correctly now.

Comment 9

[Doug Turner (:dougt)]

this patch appears to have been already pushed.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

should this be landed on 1.9.1?