459154 - test_bug343416.xul TEST-UNEXPECTED-FAIL on my Windows 2000

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1223503965.1223508038.11918.gz&fulltext=1
Win2k3 comm-central dep unit test on 2008/10/08 15:12:45

{
...
*** 936 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | The idle time should have increased by roughly the amount of time it took for the timeout to fire.
*** 937 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | The subject of the notification should be the nsIIdleService.
*** 938 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | We should be able to remove our observer here.
*** 939 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | We set a timeout and it should have fired by now.
*** 940 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | We added a listener and it should have been called by now.
}

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081009 SeaMonkey/2.0a2pre] (home, optim default) (W2Ksp4)

{
...
936 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | The idle time should have increased by roughly the amount of time it took for the timeout to fire.
937 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | We set a timeout and it should have fired by now.
938 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | We added a listener and it should have been called by now.
939 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | We added a listener and we should be able to remove it.
941 INFO Running chrome://mochikit/content/chrome/widget/test/test_bug444800.xul...
}

*****

(unrelated:)
Missing space in "normalcircumstances":
{
*** 935 INFO TEST-PASS | chrome://mochikit/content/chrome/widget/test/test_bug343416.xul | Getting the idle time should not fail in normalcircumstances on any tier 1 platform.
}

Comment 1

[:Gijs (he/him)]

You know that you're not supposed to touch the keyboard/mouse/input devices while running that test, right? And you're sure that's not what caused the failure?

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) text nits [Checkin: Comment 5]

(In reply to comment #1)

You're right, something must have gone wrong on my previous test run:
now, this test succeeds.

*****

This patches fixes a few text nits.

Comment 3

[:Gijs (he/him)]

Comment on attachment 342431 [details] [diff] [review]
(Av1) text nits
[Checkin: Comment 5]

I'm not a peer or owner for this module, so I can't do this review, strictly speaking. However, the first two changes (s/where/when/, s/Time/time/) look good, but I don't see the point of the last change, which afaict just changes the splitting point of the string in code?

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 342431 [details] [diff] [review]
(Av1) text nits
[Checkin: Comment 5]


(In reply to comment #3)

The 3rd change adds the missing space.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 342431 [details] [diff] [review]
(Av1) text nits
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/f79c2c37aaf2