Closed Bug 459214 Opened 17 years ago Closed 17 years ago

make commits from ReleaseTaggingFactory use hgUsername instead of hardcoding 'cltbld'

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

(Whiteboard: [hg-automation])

Attachments

(1 file, 1 obsolete file)

Two things here: 1) s/cltbld/ffxbld/ in the existing message. 2) Pass in '-u ffxbld' to avoid an ugly username such as cltbld@moz2-linux-slave1.build.mozilla.org
Whiteboard: [hg-automation]
Attached patch commit as 'ffxbld' (obsolete) — Splinter Review
Turns out that I was reading the hgweb shortlog wrong - we only need to do #2.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #342423 - Flags: review?(nthomas)
Comment on attachment 342423 [details] [diff] [review] commit as 'ffxbld' r+ if you also fix the hg tag at line 828.
Attachment #342423 - Flags: review?(nthomas) → review+
Attachment #342423 - Flags: review+ → review-
Comment on attachment 342423 [details] [diff] [review] commit as 'ffxbld' Actually no, use hgUsername as well.
Thanks for catching those Nick.
Attachment #342423 - Attachment is obsolete: true
Attachment #342594 - Flags: review?(nthomas)
Attachment #342594 - Flags: review?(nthomas) → review+
Comment on attachment 342594 [details] [diff] [review] [checked in] use hgUsername for commit and tag operations Checking in factory.py; /cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v <-- factory.py new revision: 1.20; previous revision: 1.19 done
Attachment #342594 - Attachment description: use hgUsername for commit and tag operations → [checked in] use hgUsername for commit and tag operations
Summary: make 'hg commit' in ReleaseTaggingFactory say 'ffxbld' instead of 'cltbld' → make commits from ReleaseTaggingFactory use hgUsername instead of hardcoding 'cltbld'
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: