Closed Bug 459313 Opened 12 years ago Closed 12 years ago

QA companion uses wrong pref for determining tab opening behavior

Categories

(Other Applications Graveyard :: QA Companion, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Gavin, Assigned: cmtalbert)

Details

Attachments

(1 file)

Bug 324164 is going to remove browser.link.open_external, since it always has the same value as browser.link.open_newwindow since at least Firefox 2.

The end result is that the code at:
http://mxr.mozilla.org/mozilla/search?string=browser.link.open_external&find=extensions

needs to use browser.link.open_newwindow instead.
Priority: -- → P1
Patch to switch the pref
Assignee: nobody → ctalbert
Status: NEW → ASSIGNED
Attachment #349888 - Flags: review?(brian)
Comment on attachment 349888 [details] [diff] [review]
Patch to change the pref

Looks fine.
Attachment #349888 - Flags: review?(brian) → review+
Checked in.
Checking in chrome/content/common.js;
/cvsroot/mozilla/testing/extensions/community/chrome/content/common.js,v  <--  common.js
new revision: 1.7; previous revision: 1.6
done
Checking in chrome/content/tabs/bugzilla.js;
/cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/bugzilla.js,v  <--  bugzilla.js
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.