459313 - QA companion uses wrong pref for determining tab opening behavior

Status: RESOLVED FIXED

(Other Applications Graveyard :: QA Companion, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 324164 is going to remove browser.link.open_external, since it always has the same value as browser.link.open_newwindow since at least Firefox 2.

The end result is that the code at:
http://mxr.mozilla.org/mozilla/search?string=browser.link.open_external&find=extensions

needs to use browser.link.open_newwindow instead.

Comment 1

[cmtalbert]

Attachment: Patch to change the pref

Patch to switch the pref

Comment 2

[Brian King [:kinger]]

Comment on attachment 349888 [details] [diff] [review]
Patch to change the pref

Looks fine.

Comment 3

[cmtalbert]

Checked in.
Checking in chrome/content/common.js;
/cvsroot/mozilla/testing/extensions/community/chrome/content/common.js,v  <--  common.js
new revision: 1.7; previous revision: 1.6
done
Checking in chrome/content/tabs/bugzilla.js;
/cvsroot/mozilla/testing/extensions/community/chrome/content/tabs/bugzilla.js,v  <--  bugzilla.js
new revision: 1.3; previous revision: 1.2
done