Closed
Bug 459333
Opened 16 years ago
Closed 16 years ago
Fix (leftover) regression from bug 199298
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
8.16 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Bug 199298 comment 10 { From Serge Gautherie 2005-07-31 09:43:59 PDT (In reply to comment #7) > Created an attachment (id=164650) [edit] [details] > proposed fix |tPath| was removed, but the following line update was missed: {{ 617 MAPI_TRACE1( "~~ERROR~~ OpenStreamOnFile failed - temp path: %s\r\n", tPath); }} Can you fix this too ? }
|
Assignee | |
Comment 1•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081009 SeaMonkey/2.0a2pre] (home, debug default) (W2Ksp4) (compiled, but not run: should be trivial enough)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #342525 -
Flags: superreview?(bienvenu)
Attachment #342525 -
Flags: review?(bienvenu)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 342525 [details] [diff] [review] (Av1) Make it compile with MAPI_DEBUG [Checkin: Comment 3] one nit - you don't need to cast string.get to a const char *; it already is one, isn't it?
Attachment #342525 -
Flags: superreview?(bienvenu)
Attachment #342525 -
Flags: superreview+
Attachment #342525 -
Flags: review?(bienvenu)
Attachment #342525 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 342525 [details] [diff] [review] (Av1) Make it compile with MAPI_DEBUG [Checkin: Comment 3] http://hg.mozilla.org/comm-central/rev/c46cb5eed927 with comment 2 suggestion. See http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsStringAPI.h?mark=786,847#750
Attachment #342525 -
Attachment description: (Av1) Make it compile with MAPI_DEBUG → (Av1) Make it compile with MAPI_DEBUG
[Checkin: Comment 3]
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•