Calendar and task tabs should be persistent

RESOLVED FIXED in 1.0b1

Status

Calendar
Lightning Only
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: Andreas Treumann, Assigned: Fallen)

Tracking

Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [not needed beta][no l10n impact])

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
STEPS TO REPRODUCE:
===================

- open the calendar and/or the task tab
- restart thunderbird


RESULT:
=======

- only the mail tab is open  

EXPECTED RESULT:
================

- after restart also the calendar/task tab should visible

REPRODUCIBLE:
=============

- always
(Reporter)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 459096
Status: RESOLVED → VERIFIED
Bug 459096 has been fixed by Bug 498106, but only for mail tabs. Session restore for calendar and task tab still doesn't work -> reopen.
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Status: REOPENED → NEW
(Assignee)

Comment 3

9 years ago
We should fix this for 1.0. It would be nice to take this for the beta, but thats not a must.
Flags: blocking-calendar1.0+
Whiteboard: [not needed beta][no l10n impact]
(Assignee)

Comment 4

9 years ago
Created attachment 393435 [details] [diff] [review]
Fix - v1

This turns out to be much easier than I thought.

Patch persists the calendar and task tab, additionally persisting the currently selected day for the calendar tab.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #393435 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #393435 - Flags: review? → review?(mschroeder)
Comment on attachment 393435 [details] [diff] [review]
Fix - v1

r=mschroeder with following nits:

>--- a/calendar/lightning/content/messenger-overlay-sidebar.js
>+++ b/calendar/lightning/content/messenger-overlay-sidebar.js
>@@ -68,6 +68,10 @@
>             // foreground.
>             ltnSwitch2Calendar();
>         }
>+
>+        if (("selectedDay" in aArgs) && aArgs.selectedDay != null) {
>+            currentView().goToDay(aArgs.selectedDay);
>+        }
>       },
>       showTab: function(aTab) {

Add empty line before the function.

>+      onTitleChanged: function(aTab) {
>+        // Make sure the title is updated.
>+        // TODO We should move this to a dedicated string some time.
>+        aTab.title = document.getElementById("calendar-tab-button").getAttribute("tooltiptext");
>+      },

Has there already a bug been filed? I'm not sure.

>+      supportsCommand: function (tab, command) calendarController.supportsCommand(command),
>+      isCommandEnabled: function (tab, command) calendarController.isCommandEnabled(command),
>+      doCommand: function(tab, command) calendarController.doCommand(command),
>+      onEvent: function(tab, event) calendarController.onEvent(event)
>+
>     },

Remove empty line before end of block.

>+      supportsCommand: function (tab, command) calendarController.supportsCommand(command),
>+      isCommandEnabled: function (tab, command) calendarController.isCommandEnabled(command),
>+      doCommand: function(tab, command) calendarController.doCommand(command),
>+      onEvent: function(tab, event) calendarController.onEvent(event)

Maybe it's better to adhere to the API using aTab, aCommand and aEvent as arguments. Also true for the calendar tab code above.
Attachment #393435 - Flags: review?(mschroeder) → review+
(Assignee)

Comment 6

9 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/07c4ff099a14>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
(Assignee)

Comment 7

9 years ago
(In reply to comment #5)
> Has there already a bug been filed? I'm not sure.

Filed bug 511518.
(Assignee)

Comment 8

7 years ago
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.