459406 - "Save" button in query search is corrupted

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P4)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of save button in organize bookmarks

See attached screenshot, the "save" button which comes up when you generate a query in Places does not look right.

Comment 1

[Marcia Knous [:marcia]]

Seen using Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1) Gecko/20081007 Firefox/3.1b1

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Marcia, your screenshot is really too small (it doesn't show enough
context).

How do you "generate a query in Places"?

Does the problem also happen on other platforms (Windows, Linux)?

Comment 3

[Marcia Knous [:marcia]]

The issue exists on trunk as well as Firefox 3.0.3, but the problem does not happen on Windows Vista as far as I can see as the button is a different shape on that platform. Although the screenshot is not that clear, you can see how the top left hand part of the button seems raised.

To generate a query in Places, Go to Bookmarks->Organize Bookmarks and type something in the Search field. that will generate the button.

Comment 4

[Marcia Knous [:marcia]]

Attachment: Better quality screenshot?

I tried another method to get a better quality screenshot...

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Ah, now I see the problem -- the left eighth (or so) of the Save
button is pushed up one or two pixels.

I see this (in Firefox 3.0.3) on both OS X 10.5.5 and 10.4.11.  I
don't see it on Windows XP or Linux.

I'd bet it's an artifact of the button having been scaled (by code in
nsNativeThemeCocoa.mm), and that this is therefore a Cocoa widgets
bug (or really an Apple bug, if the OS's scaling code is at fault).

I'd really appreciate it if you could find a regression range.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

P4, since this is really a pretty minor problem.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Markus, feel free to take this if you want.

It's not really in my area of expertise :-)

Comment 8

[Markus Stange [:mstange]]

The bug has gone. I suspect it was fixed by bug 458487, but I'm not sure.