Growl alerts should be allowed to happen at the same time.

RESOLVED FIXED in Thunderbird 3.0rc1

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: standard8, Assigned: humph)

Tracking

Trunk
Thunderbird 3.0rc1
All
Mac OS X
Dependency tree / graph
Bug Flags:
wanted-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
From bug 308552 comment 99:

* Not showing an(other) alert when we are already showing one, while the right
thing for the other platforms, is probably the wrong thing for us. You can set
Growl's persistence time up to 10 seconds, in which case biffing multiple
accounts will skip notification for a timing-dependent number of them, or you
can make alerts sticky (either always or on idle), in which case we'll do no
more notification until you dismiss that first one.
Flags: wanted-thunderbird3+
(Assignee)

Comment 1

10 years ago
I think figuring out the content and number of concurrent alerts (bug 460287) has an impact on this one.
Depends on: 460287
(Assignee)

Comment 2

10 years ago
Bug 459483 comment 5 might be fall-out from this.
(Assignee)

Updated

10 years ago
Assignee: nobody → david.humphrey
(Assignee)

Comment 3

10 years ago
DavidA pointed out that users who have "Leave notifications on screen after X seconds of inactivity" for the Growl pref get multiple notifications piling up.  Perhaps we can be smarter about how we do new notifications if previous ones haven't finished yet (not sure that's possible).

Also, I've now experienced the case of multiple accounts getting biff at the same time, and we only let 1 through.  

I'll take a look at both of these.
(Assignee)

Comment 4

10 years ago
So I've looked at this a bit more, and I'm starting to think that we can just throw away our use of mAlertInProgress for Mac.  Since we're moving to 1 alert for multiple mails (bug 460287), this is really "allow alerts for multiple accounts at once."  I did a test and getting rid of the |if (mAlertInProgress) return NS_OK;| in nsMessengerOSXIntegration::ShowAlertMessage let's me safely get alerts for multiple accounts with biff at once.

When we land bug 465381 it will mean that notifications will happen for all cases of new mail, not just for biff changing state the first time.  I still think we can safely ignore mAlertInProgress in this case.

This only leaves DavidA's case of sticky alerts and what to do there.  I've done some testing, and our growl code does deal with this case (i.e., OnAlertFinished won't happen until you clear the sticky alert).  If you tell me what the "right" thing to do here is, I can do it.
Depends on: 465381

Comment 5

10 years ago
If I get at the moment new mails for two (or more) accounts at the same time, than I only get a notification for one account (for the first retrieved account). This isn't ideal.
Isn't it possible to inform about new mails like developed in Bug 460287 and give each account in Thunderbird it's own growl notification? I don't know how to do this in the mozilla code, but with growlnotify you can display two (or more) growl notifications at exactly the same time if you do (in the Terminal):
growlnotify -a 'Problem Reporter' -t 'Example 1' -m 'Message 1' && growlnotify -a 'Problem Reporter' -t 'Example 2' -m 'Message 2'
So this shouldn't be the problem.
(Assignee)

Comment 6

10 years ago
That's what my fix mentioned above will do.  In my tree now, I get growl-per-account happening at the same time.

Comment 7

10 years ago
(In reply to comment #6)
> That's what my fix mentioned above will do.  In my tree now, I get
> growl-per-account happening at the same time.
OK, than I would love your mentioned fix. :)
(Reporter)

Updated

10 years ago
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0rc1
(Assignee)

Comment 8

10 years ago
Created attachment 362055 [details] [diff] [review]
Allow multiple growl alerts at once

Now that new mail alerts are 1 per account vs. 1 per message, showing multiple at once is fine.
Attachment #362055 - Flags: review?(bienvenu)

Comment 9

10 years ago
Oh, this is nice patch, and so curtly. :) But why do I get three notifications for two new mails?
(Assignee)

Comment 10

10 years ago
Have you updated your tree to pick-up the changes from bug 460287, which landed very recently?  That would cause it, but post-460287, you should get notification-per-account.

Comment 11

10 years ago
Hm yes, I've updated my tree. I do this everytime before building...
(Assignee)

Comment 12

10 years ago
(In reply to comment #11)
> Hm yes, I've updated my tree. I do this everytime before building...

Are the 3 mails going to 3 different folders within the same account?  Can you put up a screenshot?  I'm running with this patch in my tree now, and I don't get what you do.

Comment 13

10 years ago
Hm. In my todays build I also doesn't see this anymore. Maybe there was something wrong with my yesterdays build... If I will see this again I let you know.

Comment 14

10 years ago
Comment on attachment 362055 [details] [diff] [review]
Allow multiple growl alerts at once

r/sr=bienvenu
Attachment #362055 - Flags: superreview+
Attachment #362055 - Flags: review?(bienvenu)
Attachment #362055 - Flags: review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed

Comment 15

10 years ago
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Comment 16

9 years ago
(In reply to comment #13)
> If I will see this again I let you
> know.
Today I had a similar phenomenon. I received one mail for one account, but got two notifications for it (with the same entry). But I was not able to reproduce it (and haven't seen this before).
Is it possible to retrieve a already retrieved mail a second time? So I can test if this will happen only with "special" mails (e.g. with special attributes).
(Assignee)

Comment 17

9 years ago
> Today I had a similar phenomenon. I received one mail for one account, but got
> two notifications for it (with the same entry). But I was not able to reproduce

Questions:

* Is this the same mail in the same account, or do you have mail getting forwarded from one account to another?

* Do you have filters on the folder?

* Is this being moved to trash or otherwise moved when it comes in?

I am trying to think of other issues that could cause it.  Tell me more about what you're seeing and your setup.

Comment 18

9 years ago
(In reply to comment #17)
> Questions:
> 
> * Is this the same mail in the same account, or do you have mail getting
> forwarded from one account to another?
Yes, its the same mail in the same account. But this mail was from an electronic mailing list from my university. Today I received another mail from this list, but this mail gives me a normal behavior. So I've tried to compare the source of both mails, but I don't no what I should look for.

> * Do you have filters on the folder?
No filters.

> * Is this being moved to trash or otherwise moved when it comes in?
No, its not moved.
You need to log in before you can comment on or make changes to this bug.