459493 - remove placesBackground

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

once we move all code to async queries we should remove placesBackground, since it's unused for now.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

asking R+SR and approval to land

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 346743 [details] [diff] [review]
patch

sr is most likely not needed to land with approval

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/35826c8d3198

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

I went round the mac machines and removed assorted copies of PlacesBackground.jsm from dist/ directories. Mac doesn't clean up properly between runs, or do packaging the same as win32/linux, so we were getting rsync errors
building file list ... file has vanished: "/builds/buildbot/moz2-slave/mozilla-central-macosx/build/obj-firefox/ppc/dist/Minefield.app/Contents/MacOS/modules/PlacesBackground.jsm"

Comment 5

[Tracy Walker [:tracy]]

verified per comment #4

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv