Closed Bug 459493 Opened 12 years ago Closed 11 years ago

remove placesBackground

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.1b2

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file)

once we move all code to async queries we should remove placesBackground, since it's unused for now.
No longer depends on: 459491
Flags: blocking-firefox3.1?
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3.1b2
Attached patch patchSplinter Review
asking R+SR and approval to land
Attachment #346743 - Flags: superreview?(mconnor)
Attachment #346743 - Flags: review?(mconnor)
Attachment #346743 - Flags: approval1.9.1b2?
Comment on attachment 346743 [details] [diff] [review]
patch

sr is most likely not needed to land with approval
Attachment #346743 - Flags: superreview?(mconnor)
Attachment #346743 - Flags: review?(mconnor)
Attachment #346743 - Flags: review+
Attachment #346743 - Flags: approval1.9.1b2?
Attachment #346743 - Flags: approval1.9.1b2+
http://hg.mozilla.org/mozilla-central/rev/35826c8d3198
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: blocking-firefox3.1?
I went round the mac machines and removed assorted copies of PlacesBackground.jsm from dist/ directories. Mac doesn't clean up properly between runs, or do packaging the same as win32/linux, so we were getting rsync errors
building file list ... file has vanished: "/builds/buildbot/moz2-slave/mozilla-central-macosx/build/obj-firefox/ppc/dist/Minefield.app/Contents/MacOS/modules/PlacesBackground.jsm"
verified per comment #4
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.