Closed Bug 459572 Opened 11 years ago Closed 8 years ago

PR_CreateProcess in NSPR needs unicode support

Categories

(NSPR :: NSPR, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: jboston, Assigned: wtc)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Firefox/3.0

The NSPR implementation for starting processes only accepts char* so it won't work with international character sets. 

See:
http://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/include/prproces.h#98

It would be useful to have an implementation that accepts PRUnichar* arguments. 

Reproducible: Always

Actual Results:  
Doesn't work.
This patch converts the interface to accept Unicode arguments. It is Windows only at this stage. I plan to submit another patch with Unix support, but this shows the direction I am taking.
Comment on attachment 347537 [details] [diff] [review]
Unicode support for Windows processes

Thanks for the patch.

This patch doesn't modify any NSPR code.  If future versions of
this patch will modify NSPR code, please note that the function
prototypes declared in prproces.h are public and need to stay
the same for backward compatibility, so you'll need to add a new
function for Unicode support.

If future versions of this patch will not modify NSPR code, please
change the product of this bug to "Core" and the component to
"XPCOM".
Thanks for the patch, but we now have runw for this.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
(Well, it doesn't fix NSPR though, so feel free to reopen if you have a patch for that.)
You need to log in before you can comment on or make changes to this bug.